From owner-cvs-sys  Fri Sep  6 10:39:38 1996
Return-Path: owner-cvs-sys
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id KAA16073
          for cvs-sys-outgoing; Fri, 6 Sep 1996 10:39:38 -0700 (PDT)
Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id KAA16066;
          Fri, 6 Sep 1996 10:39:33 -0700 (PDT)
Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.6.12/8.6.12) id KAA13211; Fri, 6 Sep 1996 10:39:19 -0700
From: "Rodney W. Grimes" <rgrimes@GndRsh.aac.dev.com>
Message-Id: <199609061739.KAA13211@GndRsh.aac.dev.com>
Subject: Re: cvs commit:  src/sys/pci pcisupport.c
To: se@zpr.uni-koeln.de (Stefan Esser)
Date: Fri, 6 Sep 1996 10:39:19 -0700 (PDT)
Cc: rgrimes@freefall.freebsd.org, CVS-committers@freefall.freebsd.org,
        cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
In-Reply-To: <199609061708.TAA16633@x14.mi.uni-koeln.de> from Stefan Esser at "Sep 6, 96 07:08:57 pm"
X-Mailer: ELM [version 2.4ME+ PL11 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> Rodney W. Grimes writes:
>  > > rgrimes     96/09/06 02:17:09
>  > > 
>  > Looking at this file and all the #if defined (I686_CPU) cruft and the
>  > ordering of chipsets makes me want a cleaner approach.  Also you have
>  > to be _VERY_ carefull on what you exclude from certain CPU classes,
>  > especially with devices other than HOST/PCI bridges (ie, a PCI/anything
>  > bridge _can_ be used with _ANY_ cpu class.
> 
> Well, I did make sure I got that right, 
> but the #if defined (Ix86_CPU) will all
> go away again, since it was an outright
> silly idea ...

Not really a silly idea, just the implementation of how it is makes
it kinda messy, not that I have a better way to do it :-(.  I'll
think on it for a while...

> See my reply to Michael Smith, who rightly
> complained about his, too ...

Yea.. now that is a much better reason for the evil #ifdef's to
go away...

>  > Stephan, do you really want to be doing that in here??
> 
> No, I really don't, anymore ...

Okay.  This simplifies my next round of patches a lot, I'll wait until
after this is cleaned up.
 
> I'll back those changes out, if you don't
> beat me on it (which shouldn't be too hard 
> given your much better connectivity to 
> Freefall :)

If you don't get to it today, I'll probably back them out tomarrow some
time.  Oh, and are you doing any more major work in there?  I want to
do some reorg and major comment cleanup (I'll pass a diff by the list
first).  Then I will be adding full register dump support for 439HX,
440FX and associated functions/chips (got to figure out how to get
the USB function of the 82371SB turned on first though :-)).

-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD