From owner-svn-src-head@freebsd.org Thu Mar 17 04:37:24 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3944AAD2A59 for ; Thu, 17 Mar 2016 04:37:24 +0000 (UTC) (envelope-from sef@ixsystems.com) Received: from barracuda.ixsystems.com (barracuda.ixsystems.com [12.229.62.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.ixsystems.com", Issuer "Go Daddy Secure Certificate Authority - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 132D1F31 for ; Thu, 17 Mar 2016 04:37:23 +0000 (UTC) (envelope-from sef@ixsystems.com) X-ASG-Debug-ID: 1458189442-08ca04178819bd70001-SDoC61 Received: from zimbra.ixsystems.com ([10.246.0.20]) by barracuda.ixsystems.com with ESMTP id ADSRLfCPpqjfJv63 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 16 Mar 2016 21:37:22 -0700 (PDT) X-Barracuda-Envelope-From: sef@ixsystems.com X-Barracuda-RBL-Trusted-Forwarder: 10.246.0.20 X-ASG-Whitelist: Client Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id 70776C07E5E; Wed, 16 Mar 2016 21:37:22 -0700 (PDT) Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id G2hYycJrqbsY; Wed, 16 Mar 2016 21:37:21 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id D8B11C07EB3; Wed, 16 Mar 2016 21:37:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at ixsystems.com Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XqUNX251xQOX; Wed, 16 Mar 2016 21:37:21 -0700 (PDT) Received: from [192.168.0.115] (173-164-180-199-SFBA.hfc.comcastbusiness.net [173.164.180.199]) by zimbra.ixsystems.com (Postfix) with ESMTPSA id 9C8F5C07E5E; Wed, 16 Mar 2016 21:37:21 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools From: Sean Fagan X-ASG-Orig-Subj: Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools In-Reply-To: Date: Wed, 16 Mar 2016 21:37:21 -0700 Cc: Alan Somers , Xin LI , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <201509040014.t840ELno034811@repo.freebsd.org> To: Xin LI X-Mailer: Apple Mail (2.3112) X-Barracuda-Connect: UNKNOWN[10.246.0.20] X-Barracuda-Start-Time: 1458189442 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://10.246.0.26:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ixsystems.com X-Barracuda-BRTS-Status: 1 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2016 04:37:24 -0000 As I recall, from ZFS, but I=E2=80=99m not positive. Either that, or = something else was using 0x40. Sean. > On Mar 16, 2016, at 9:29 PM, Xin LI wrote: >=20 > +sef who created the patch... >=20 > On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers = wrote: >>=20 >>=20 >> On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: >>>=20 >>> Author: delphij >>> Date: Fri Sep 4 00:14:20 2015 >>> New Revision: 287445 >>> URL: https://svnweb.freebsd.org/changeset/base/287445 >>>=20 >>> Log: >>> Expose an interface to determine if an ACE is inherited. >>>=20 >>> Submitted by: sef >>> Reviewed by: trasz >>> MFC after: 2 weeks >>> Differential Revision: https://reviews.freebsd.org/D3540 >>>=20 >>> Modified: >>> head/bin/setfacl/setfacl.1 >>> head/lib/libc/posix1e/acl_add_flag_np.3 >>> head/lib/libc/posix1e/acl_support_nfs4.c >>> head/share/man/man9/acl.9 >>> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c >>> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h >>> head/sys/kern/subr_acl_nfs4.c >>> head/sys/sys/acl.h >>> head/tools/regression/acltools/tools-crossfs.test >>> head/tools/regression/acltools/tools-nfs4-psarc.test >>> head/tools/regression/acltools/tools-nfs4-trivial.test >>> head/tools/regression/acltools/tools-nfs4.test >>=20 >>=20 >> ... >>=20 >>>=20 >>> Modified: head/sys/sys/acl.h >>>=20 >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015 (r287444) >>> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015 (r287445) >>> @@ -249,11 +249,12 @@ typedef void *acl_t; >>> #define ACL_ENTRY_INHERIT_ONLY 0x0008 >>> #define ACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 >>> #define ACL_ENTRY_FAILED_ACCESS 0x0020 >>> +#define ACL_ENTRY_INHERITED 0x0080 >>>=20 >>> #define ACL_FLAGS_BITS = (ACL_ENTRY_FILE_INHERIT | >>> \ >>> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ >>> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ >>> - ACL_ENTRY_FAILED_ACCESS) >>> + ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) >>>=20 >>> /* >>> * Undefined value in ae_id field. ae_id should be set to this = value >>=20 >>=20 >> Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED = instead >> of 0x0040 ? >>=20 >=20 >=20 >=20 > --=20 > Xin LI https://www.delphij.net/ > FreeBSD - The Power to Serve! Live free or die