From owner-freebsd-current@FreeBSD.ORG Wed Mar 10 10:16:16 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12D9C16A595 for ; Wed, 10 Mar 2004 10:16:16 -0800 (PST) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB85943D3F for ; Wed, 10 Mar 2004 10:16:15 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 21427 invoked from network); 10 Mar 2004 18:16:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 10 Mar 2004 18:16:15 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i2AIFD2B030405; Wed, 10 Mar 2004 13:15:56 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Wed, 10 Mar 2004 13:09:32 -0500 User-Agent: KMail/1.6 References: <7m7jxth70h.wl@black.imgsrc.co.jp> In-Reply-To: <7m7jxth70h.wl@black.imgsrc.co.jp> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200403101309.32292.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Jun Kuriyama Subject: Re: Expand libdisk to use 64bit size/offset X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2004 18:16:16 -0000 On Tuesday 09 March 2004 07:37 pm, Jun Kuriyama wrote: > I found sysinstall(8) cannot handle TB class storage. It looks > both of libdisk and sysinstall should be fixed. > > I'm trying to improve this situation, but I'm not sure I'm going to > the right direction. Please look this patch (including my debugging > stuff and XXX comments which should be resolved/removed). > > http://www.imgsrc.co.jp/~kuriyama/BSD/libdisk-20040310.diff > > I choose daddr_t as larger storage for offset, size and end member of > "struct chunk". I think offset and end is okay, but I don't know > daddr_t for offset is correct or not. dadd_t is a uint32_t, so it won't help. Just use off_t for chunk offset/size/end. > And, In Write_Disk() at write_i386_disk.c, over 256 is stored in > dp_ecyl and this member is unsigned char on i386. Is this something > wrong? > > > if (i > 1023) > > i = 1023; > > dp[j].dp_ecyl = i; Cylinders are encoded via magic with the lower 8 bits in one byte and 2 other bits stored in the sector number. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org