From owner-freebsd-hackers Sat Jan 10 20:00:51 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.7/8.8.7) id UAA06920 for hackers-outgoing; Sat, 10 Jan 1998 20:00:51 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id UAA06876 for ; Sat, 10 Jan 1998 20:00:27 -0800 (PST) (envelope-from brian@awfulhak.org) Received: from gate.lan.awfulhak.org (localhost [127.0.0.1]) by awfulhak.demon.co.uk (8.8.7/8.8.7) with ESMTP id DAA20820 for ; Sun, 11 Jan 1998 03:42:30 GMT (envelope-from brian@gate.lan.awfulhak.org) Message-Id: <199801110342.DAA20820@awfulhak.demon.co.uk> X-Mailer: exmh version 2.0.1 12/23/97 To: freebsd-hackers@FreeBSD.ORG Subject: Change to config(8) Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 11 Jan 1998 03:42:29 +0000 From: Brian Somers Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk Hi, I'd like to commit this change, but I don't know if it's correct. AFAICT, because the minor() bit of a dev_t is only 8 bits, minors of > 256 are useless. They also break the -current DEVFS code in that you end up with an increased major number (oops!) if you (for example) pseudo-device tun 257 However, I haven't committed it because I don't know where things like /dev/sd0s1 get their minors (0x00020002). -- Brian , , Don't _EVER_ lose your sense of humour.... Index: mkheaders.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/config/mkheaders.c,v retrieving revision 1.8 diff -c -r1.8 mkheaders.c *** mkheaders.c 1997/11/07 00:09:40 1.8 --- mkheaders.c 1998/01/11 03:40:28 *************** *** 129,134 **** --- 129,136 ---- FILE *inf, *outf; int inc, oldcount; + if (count > 256) + count = 256; file = toheader(hname); name = tomacro(dev); inf = fopen(file, "r");