Date: Wed, 20 Oct 2004 12:44:46 +0200 (CEST) From: Simon Barner <barner@in.tum.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/72916: textproc/xerces-c: fix PTHREAD_* handling Message-ID: <20041020104446.B1AA3C0ED@zi025.glhnet.mhn.de> Resent-Message-ID: <200410201050.i9KAoLux034142@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 72916
>Category: ports
>Synopsis: textproc/xerces-c: fix PTHREAD_* handling
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 20 10:50:21 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Simon Barner
>Release: FreeBSD 5.3-BETA6 i386
>Organization:
>Environment:
FreeBSD zi025.glhnet.mhn.de 5.3-BETA6 FreeBSD 5.3-BETA6#0: Mon Aug 23 14:34:13
CEST 2004 root@zi025.glhnet.mhn.de:/mnt/fbsd521/usr/src/sys/i386/compile/KIS
TE i386
>Description:
This port is currently marked FORBIDDEN since it does not respect
PTHREAD_{CFLAGS, LIBS}.
The attached patch fixes this issue.
>How-To-Repeat:
Try to build port...
>Fix:
--- xerces-c.patch begins here ---
diff -ruN xerces-c.orig/Makefile xerces-c/Makefile
--- xerces-c.orig/Makefile Tue Feb 17 10:57:41 2004
+++ xerces-c/Makefile Wed Oct 20 12:31:26 2004
@@ -30,7 +30,9 @@
HAS_CONFIGURE= yes
CONFIGURE_SCRIPT= runConfigure
-CONFIGURE_ENV+= XERCESCROOT=${WRKSRC} TRANSCODER="IconvFBSD"
+CONFIGURE_ENV+= XERCESCROOT=${WRKSRC} TRANSCODER="IconvFBSD" \
+ PTHREAD_LIBS="${PTHREAD_LIBS}" \
+ PTHREAD_CFLAGS="${PTHREAD_CFLAGS}"
CONFIGURE_ARGS= -p freebsd -n socket -P ${PREFIX}
.if defined(NO_THREADS)
CONFIGURE_ARGS+= -r none
@@ -39,10 +41,6 @@
PLIST_SUB+= XERCESC_VER=${PORTVERSION:S/./_/g} \
.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} >= 502102
-FORBIDDEN= "Does not respect PTHREAD_{CFLAGS,LIBS}"
-.endif
pre-configure:
${CHMOD} 700 ${CONFIGURE_WRKSRC}/runConfigure
diff -ruN xerces-c.orig/files/patch-src::xercesc::runConfigure xerces-c/files/patch-src::xercesc::runConfigure
--- xerces-c.orig/files/patch-src::xercesc::runConfigure Thu Jan 1 01:00:00 1970
+++ xerces-c/files/patch-src::xercesc::runConfigure Wed Oct 20 12:27:08 2004
@@ -0,0 +1,13 @@
+--- src/xercesc/runConfigure.orig Wed Oct 20 12:25:47 2004
++++ src/xercesc/runConfigure Wed Oct 20 12:26:33 2004
+@@ -294,8 +294,8 @@
+ ;;
+ esac
+ elif test $platform = "freebsd"; then
+- threadingLibs="-pthread -lc_r"
+- threadingDefines="-D_THREAD_SAFE -DXML_USE_PTHREADS"
++ threadingLibs="${PTHREAD_LIBS}"
++ threadingDefines="${PTHREAD_CFLAGS} -DXML_USE_PTHREADS"
+ elif test $platform = "aix"; then
+ aix_version=`./config.guess`;
+ echo Found host system to be $aix_version
--- xerces-c.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041020104446.B1AA3C0ED>