From owner-cvs-src@FreeBSD.ORG Sat Feb 14 14:53:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B8A916A4CE; Sat, 14 Feb 2004 14:53:31 -0800 (PST) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85BEE43D2D; Sat, 14 Feb 2004 14:53:30 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i1EMrTLE028329; Sun, 15 Feb 2004 09:53:29 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i1EMrQ0I028935; Sun, 15 Feb 2004 09:53:27 +1100 Date: Sun, 15 Feb 2004 09:53:25 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Jun Kuriyama In-Reply-To: <7mfzdexjzs.wl@black.imgsrc.co.jp> Message-ID: <20040215094444.F6303@gamplex.bde.org> References: <200401192127.i0JLRBL3041817@repoman.freebsd.org> <20040213035557.M24031@gamplex.bde.org> <7mfzdexjzs.wl@black.imgsrc.co.jp> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2004 22:53:31 -0000 On Sat, 14 Feb 2004, Jun Kuriyama wrote: > At Fri, 13 Feb 2004 04:02:46 +1100 (EST), > Bruce Evans wrote: > > > This was rejected in all reviews. It gives less information than > > > grepping the sources, at some cost (grep at least gives correct line > > > numbers when the sources don't quite match the binary). > > > > > > Please back this out. > > > > I'm still waiting for this to be backed out. > > I also think that commit is not so useful, but there are some > supporters for his modification. Do you want to back out this > completely? Or fixing just style bugs are acceptable? Fixing the style bugs and other bugs, and adding an option (off by default) to control it would be acceptable. Backing it out would be easier. Bruce