From owner-svn-src-head@FreeBSD.ORG Mon Aug 3 07:27:28 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 046711065675; Mon, 3 Aug 2009 07:27:28 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe03.swip.net [212.247.154.65]) by mx1.freebsd.org (Postfix) with ESMTP id 36C0A8FC08; Mon, 3 Aug 2009 07:27:27 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=GB8WYDQo1twA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=6I5d2MoRAAAA:8 a=evCO53Li0c532tvo64wA:9 a=n0dlPTy1Bsx6D5iOPzfKwzgKjrgA:4 a=SV7veod9ZcQA:10 Received: from [188.126.201.140] (account mc467741@c2i.net HELO laptop.adsl.tele2.no) by mailfe03.swip.net (CommuniGate Pro SMTP 5.2.13) with ESMTPA id 1297384967; Mon, 03 Aug 2009 08:27:23 +0200 From: Hans Petter Selasky To: "Robert N. M. Watson" Date: Mon, 3 Aug 2009 08:27:19 +0200 User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA2; KDE/4.2.4; i386; ; ) References: <200907300014.n6U0EZ77086341@svn.freebsd.org> <20090802192902.GS47463@elvis.mu.org> <134A728D-F2F4-4951-81D8-704CC2DB6F9F@FreeBSD.org> In-Reply-To: <134A728D-F2F4-4951-81D8-704CC2DB6F9F@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908030827.21108.hselasky@c2i.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Alfred Perlstein , src-committers@freebsd.org, Navdeep Parhar Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2009 07:27:28 -0000 On Sunday 02 August 2009 21:58:14 Robert N. M. Watson wrote: > On 2 Aug 2009, at 20:29, Alfred Perlstein wrote: > > * Robert Watson [090801 15:15] wrote: > >> On Sat, 1 Aug 2009, Hans Petter Selasky wrote: > >>>>> This has slowed down core dumps very significantly. What used > >>>>> to take > >>>>> 10-15s on my system now takes around 3 minutes. A simple test > >>>>> is to > >>>>> break into ddb and "call doadump" with or without this rev. I > >>>>> have a > >>>>> serial console on this machine and so I can use ddb whether the > >>>>> attached > >>>>> USB keyboard works or not. > >>> > >>> It's because there is a DELAY(1000) in the UKBD's polling routine > >>> so that > >>> key- repeating will work, no magic. > >> > >> Given a choice between dumping 10x faster and having automatic key > >> repeat > >> in DDB, I'd lean towards the former. :-) > > > > Robert, and *@freebsd.org, > > > > Hans should be back in a day or so to address this. If critical I can > > probably back out the offending code, but I think it makes sense to > > wait a few days more for a more comprehensive fix. > > That's my feeling too -- however, I think it would be useful to > generate a small concept test patch that disables the key repeat > behavior and see if it restores some/all performance. Scott's argument > suggests only some, but perhaps we'd get quite a bit, which is what > we're looking for. We wouldn't commit the patch but it would let us > know we're on the right track. Hi, I'm back. I see two solutions: 1) Disable the timekeeping if no keys are pressed. 2) Second option is to use getmicrotime. Actually what I need is just a millisecond time reference so I know when to repeat the last key. Any opinions? DELAY() or getmicrotime() ? --HPS