From owner-freebsd-python@freebsd.org  Mon Apr 27 00:50:15 2020
Return-Path: <owner-freebsd-python@freebsd.org>
Delivered-To: freebsd-python@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13D4F2C2FEE
 for <freebsd-python@mailman.nyi.freebsd.org>;
 Mon, 27 Apr 2020 00:50:15 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::50:13])
 by mx1.freebsd.org (Postfix) with ESMTP id 499R5L6sj8z4CCS
 for <freebsd-python@freebsd.org>; Mon, 27 Apr 2020 00:50:14 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: by mailman.nyi.freebsd.org (Postfix)
 id E92822C2FED; Mon, 27 Apr 2020 00:50:14 +0000 (UTC)
Delivered-To: python@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id E79AA2C2FEC
 for <python@mailman.nyi.freebsd.org>; Mon, 27 Apr 2020 00:50:14 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 499R5L5bynz4CCQ
 for <python@FreeBSD.org>; Mon, 27 Apr 2020 00:50:14 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2610:1c1:1:606c::50:1d])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B758A1DD9
 for <python@FreeBSD.org>; Mon, 27 Apr 2020 00:50:14 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.5])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03R0oEUu013792
 for <python@FreeBSD.org>; Mon, 27 Apr 2020 00:50:14 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
 by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03R0oEMK013791
 for python@FreeBSD.org; Mon, 27 Apr 2020 00:50:14 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to
 bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: python@FreeBSD.org
Subject: [Bug 241565] [NEW PORT] textproc/py-iso3166: Standalone ISO 3166-1
 country definitions
Date: Mon, 27 Apr 2020 00:50:14 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: feature, needs-patch, needs-qa
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: koobs@FreeBSD.org
X-Bugzilla-Status: Open
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: kevans@freebsd.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: keywords
Message-ID: <bug-241565-21822-R9hfkMcMNN@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-241565-21822@https.bugs.freebsd.org/bugzilla/>
References: <bug-241565-21822@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-python>, 
 <mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python/>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-python>,
 <mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Apr 2020 00:50:15 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241565

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch

--- Comment #9 from Kubilay Kocak <koobs@FreeBSD.org> ---
Minor review items:

1) Match COMMENT to setup.py:description (modulo portlint compliance)
2) Package has tests shipped with it. Add TEST_DEPENDS and (do-)test target=
 for
better QA accordingly. Ask upstream to package tox.ini and declare
tests_require=3Dpytest in setup.py so it makes figuring out how to run tests
quicker/easier for downstream consumers (packages *and* users).

The above changes don't require maintainer approval (ports (python) complia=
nce)

@Kyle This needs QA confirmation (including maketest: after (2)) to progres=
s.
To assist with the test target, for pytest, the usual caonical and
deterministic invocation command is:=20

do-test:
    @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=3D

--=20
You are receiving this mail because:
You are on the CC list for the bug.=