From owner-freebsd-emulation@FreeBSD.ORG Thu Mar 17 14:01:18 2011 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E8D4106564A; Thu, 17 Mar 2011 14:01:18 +0000 (UTC) (envelope-from decke@bluelife.at) Received: from groupware.itac.at (groupware.itac.at [91.205.172.99]) by mx1.freebsd.org (Postfix) with ESMTP id A8F6A8FC12; Thu, 17 Mar 2011 14:01:17 +0000 (UTC) Received: from home.bluelife.at (93.104.210.95) by groupware.itac.at (Axigen) with (AES256-SHA encrypted) ESMTPSA id 299920; Thu, 17 Mar 2011 15:01:57 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: Thu, 17 Mar 2011 15:01:17 +0100 From: Bernhard Froehlich To: Brandon Gooch In-Reply-To: References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <4D3F8357.2070005@freebsd.org> "<62fcd16074e526547c3417a8f259174e@bluelife.at>" <8662tbkahz.fsf@zhuzha.ua1> <4c9ee35c7798936a1e35259d72af781c@bluelife.at> <8b39481bb24314e2d543b7544f12a447@bluelife.at> Message-ID: <693ef9e6a28dc6da96e2294f0f1d0c95@bluelife.at> X-Sender: decke@bluelife.at User-Agent: Roundcube Webmail/0.5.1 X-AxigenSpam-Level: 1 X-CTCH-RefID: str=0001.0A0B0205.4D82142C.0193,ss=1,fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Cc: freebsd-emulation@freebsd.org, Julian Elischer , freebsd-virtualization@freebsd.org Subject: Re: VirtualBox + VIMAGE X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2011 14:01:18 -0000 On Wed, 2 Mar 2011 15:09:21 -0600, Brandon Gooch wrote: > On Wed, Mar 2, 2011 at 2:52 PM, Bernhard Froehlich wrote: >> On Wed, 02 Mar 2011 21:31:45 +0100, Bernhard Froehlich wrote: >>> On Wed, 2 Mar 2011 08:30:01 -0600, Brandon Gooch wrote: >>>> On Wed, Jan 26, 2011 at 5:19 PM, Bernhard Froehlich >>>> wrote: >>>>> On Wed, 26 Jan 2011 16:25:28 +0200, Mikolaj Golub wrote: >>>>>> On Wed, 26 Jan 2011 10:22:40 +0100 Bernhard Froehlich wrote: >>>>>> >>>>>>  BF> Sounds like it's my turn now. Which FreeBSD version is required to be >>>>>>  BF> able to use it? >>>>>> >>>>>> As Bjoern noted it is for __FreeBSD_version >= 800500. >>>>>> >>>>>>  BF> Is VIMAGE enabled per default and what happens if VIMAGE is disabled - >>>>>>  BF> does it at least build fine with that patch? >>>>>> >>>>>> We have VIMAGE disabled by default. >>>>>> >>>>>> I have added to src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile: >>>>>> >>>>>> .if defined(VIMAGE) >>>>>>  CFLAGS += -DVIMAGE >>>>>> .endif >>>>>> >>>>>> So to build the driver for VIMAGE enabled kernel one should run >>>>>> >>>>>> VIMAGE=1 make >>>>>> >>>>>> If VIMAGE variable is not defined the module for VIMAGE disabled kernel will >>>>>> be built. >>>>> >>>>> http://home.bluelife.at/patches/virtualbox-ose-kmod-devel-VIMAGE.diff >>>>> >>>>> I've integrated it a bit better into the VirtualBox build system, added >>>>> the ports stuff and updated the patch for VirtualBox 4.0.2. >>>>> >>>>> It is currently unclear to me why you add VIMAGE to CFLAGS but nowhere >>>>> check for VIMAGE in VBoxNetFlt-freebsd.c. Shouldn't we add a check for >>>>> VIMAGE in the #if defined line or is this already done somewhere deep in >>>>> the included headers? >>>>> >>>>> -- >>>>> Bernhard Froehlich >>>>> http://www.bluelife.at/ >>>> >>>> I managed to completely miss your patch posted this thread, so I just >>>> gave it a try on bluelife's virtualbox-ose-kmod svn r1239; it's >>>> working well. I've started each of my guests with bridged networking >>>> to be sure, and I see no panic (or any other anomaly) during boot or >>>> normal operation. >>>> >>>> Do you have plans on merging the patch soon? >>> >>> It's not committed because it doesn't work. What i have tested so far >>> is with stock 8.2-REL so without VIMAGE. >>> >>> enabled VIMAGE option on stock 8.2-REL: bridging works fine >>> disabled VIMAGE option on stock 8.2-REL: crashes vm with an assert >>> >>> Expression: !pPatchToGuestRec >>> Location  : >>> /usr/home/decke/blueports/emulators/virtualbox-ose/work/VirtualBox-4.0.4_OSE/src/VBox/VMM/VMMR3/PATM.cpp(116 >>> 6) void patmr3AddP2GLookupRecord(VM*, _PATCHINFO*, uint8_t*, RTRCPTR, >>> PATM_LOOKUP_TYPE, bool) >> >> It looks like that assert is not related to the VIMAGE patch. Works >> fine now since half an hour. >> >>> Could someone with an VIMAGE kernel please test the patch? Just >>> configure a VM with bridging and let it transfer a few bytes. Once with >>> the option enabled and once disabled. > > I've had a machine running a linux guest for almost a day, bridging > with a VIMAGE kernel, while capturing traffic on the virtual interface > (and performing a few other tasks) -- so far, so good. No panics, and > no anomalies. > > I surely don't know what the above mentioned assert is about; I > haven't seen such a panic myself. Thanks to everyone involved! I have committed it now to our blueports repository and the patch will come together with the next major VirtualBox update to 4.0.x. http://svn.bluelife.at/index.cgi/blueports/revision/?rev=1264 It got also reviewed from upstream and it looks fine so far. Will hopefully be committed soon. -- Bernhard Fröhlich http://www.bluelife.at/