From owner-svn-ports-head@freebsd.org Tue Mar 29 07:42:25 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 880B5AE14FE; Tue, 29 Mar 2016 07:42:25 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5BA7B1BF2; Tue, 29 Mar 2016 07:42:24 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: by shepard.synsport.net (Postfix, from userid 80) id AD77A43BED; Tue, 29 Mar 2016 02:42:23 -0500 (CDT) To: Alexey Dokuchaev Subject: Re: svn commit: r412019 - head/games/tbe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 29 Mar 2016 09:42:23 +0200 From: "John Marino (FreeBSD)" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org Mail-Reply-To: marino@freebsd.org In-Reply-To: <20160329073339.GA72433@FreeBSD.org> References: <201603272245.u2RMjdZS009225@repo.freebsd.org> <20160329073339.GA72433@FreeBSD.org> Message-ID: X-Sender: freebsd.contact@marino.st User-Agent: Roundcube Webmail/0.9.1 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2016 07:42:25 -0000 On 3/29/2016 9:33 AM, Alexey Dokuchaev wrote: > On Sun, Mar 27, 2016 at 10:45:39PM +0000, John Marino wrote: >> New Revision: 412019 >> URL: https://svnweb.freebsd.org/changeset/ports/412019 >> >> Log: >> games/tbe: Fix plist (main executable wasn't listed) >> >> At some port, this port was converted from having a plist to using >> PORTDATA as an automatic generator. Unfortunately, this excluded >> the >> main executable (bin/tbe) from being packaged as well as several >> icons. >> Drop PORTDATA and bring back the full pkg-plist (it's < 300 lines). >> While here, pet portlint. >> >> Added: >> head/games/tbe/pkg-plist (contents, props changed) > > I guess pkg-plist should've been repocopied (resurrected) in this case. > I disagree. 1) It's been gone a long time and many versions have changed since. Showing changes from back then to now has no value. 2) Repocopy makes sense to me ONCE, when creating a new port. After the port is created, don't use it within a port. I don't see people doing this and I'm glad about that. If we said it's okay returning pkg-plist, then you can claim it's okay for returning patch files, which is absurd. John