From owner-freebsd-tinderbox@FreeBSD.ORG Wed Feb 18 07:00:54 2009 Return-Path: Delivered-To: tinderbox@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95F1D1065676; Wed, 18 Feb 2009 07:00:54 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 541EB8FC1B; Wed, 18 Feb 2009 07:00:54 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n1I6wIkf042376; Tue, 17 Feb 2009 23:58:18 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 17 Feb 2009 23:58:26 -0700 (MST) Message-Id: <20090217.235826.-1697751865.imp@bsdimp.com> To: xcllnt@mac.com From: "M. Warner Losh" In-Reply-To: References: <4CB77F1D-4235-47D8-B654-1C4F29B6C649@mac.com> <20090217.234216.1276682135.imp@bsdimp.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mips@FreeBSD.org, tinderbox@FreeBSD.org, current@FreeBSD.org Subject: Re: [head tinderbox] failure on mips/mips X-BeenThere: freebsd-tinderbox@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Tinderbox reports, responses, and meta-comments" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2009 07:00:55 -0000 In message: Marcel Moolenaar writes: : : On Feb 17, 2009, at 10:42 PM, M. Warner Losh wrote: : : > : A safer approach is to mark ifi_epoch as packed or put differently, : > : define time_t as a 64-bit integral with 32-bit alignment. This can : > : avoid a lot of unexpected internal padding as well (e.g. struct : > : timeval). : > : > Marking it as packed won't help. If the elements aren't properly : > aligned, gcc won't access multi-word entities properly. It might : > eliminate the warning, but it will break at runtime. : : But GCC will use a pair of 32-bit loads and/or stores to : access the 64-bit integral in that case. There should be : no runtime breakage. You only do this for n32 of course. Why only n32? Registers are still 64-bit in n32. Warner