Date: Mon, 6 Mar 2023 23:25:06 +0900 From: Koichiro Iwao <meta@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> In-Reply-To: <ZAWLnDz5cb4vIR/j@FreeBSD.org> References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <ZAWLnDz5cb4vIR/j@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote:
> On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote:
> > commit d69b20995dec38f96ef28522bc6156a7d5b80fff
> >
> > security/softether5: add DEBUG option
> >
> > [...]
> > +.include <bsd.port.options.mk>
> > +
> > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk
> > +# just set WITH_DEBUG=yes, CMAKE_ARGS+=-DCMAKE_BUILD_TYPE=Debug takes no effect.
> > +.if ${PORT_OPTIONS:MDEBUG}
> > +WITH_DEBUG= yes
>
> We do not expose this via options. To build debug package, just
> "make -DWITH_DEBUG", don't ask users to fiddle with options.
>
> ./danfe
Really? What's the difference exposing ports vs not?
--
meta <meta@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230306142506.kckwmjxqgyv6usry>