From nobody Mon Mar 6 14:25:06 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVgpK0Rs9z3wxr4; Mon, 6 Mar 2023 14:25:13 +0000 (UTC) (envelope-from meta@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVgpJ6qmSz3jL2; Mon, 6 Mar 2023 14:25:12 +0000 (UTC) (envelope-from meta@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678112713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EQdzFMogGRiUXtqKEmd3afUK2ZVhTG4zKcV2Lu+lSes=; b=t1kSGhQXaOD+QsBUJipZIlq0xsF5I5nna/1t10cEQalS5X5DxjxlT96z4bY37veijm9ynV i8h4JVcfTPJr5M8yeaPKgJic7PKsfjSnVbQ37UxMyimK66PDjZkcgSwd6YqU4a86Zkkisi nGWvn/PYJtlgcjLJGE30wbIoAQFtdWTRcOsGfrqLTHHfQgwS2ldATyZia1lYnlmwnLh/sb /KEatr6XGWF3JOjbofOuc1ynBiUK+It4sLkwh1Aj4HXxQg4MwRjF8hxNDoHM9ccB6z/RMM mGQWN1zl6juIu8+VLcGB1gm0pMyyqrdF7HfeojrrnlDtkHQwgliPf8X5b5R52Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678112713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EQdzFMogGRiUXtqKEmd3afUK2ZVhTG4zKcV2Lu+lSes=; b=nMF+aL1tZIMJmQT/r3O9bjqI/evoYZK2stbFeODw+KdFBOGXHPAgS9fiFhfPKPT1Hazrpd /x9IYYRkXwqu6Ah076hpaCC3XsFHFobaozbk8T/WtnYSxSxfnWJjjY9JE32XXi1b1gzss8 7MJH8zkbQ+KkT+fF4vCjyYfb41q9ZZD2ia588ww+7XNwyWPYCbgxMWYdHW0Wapx8dA3fPq qJA8J4BW/eRcFobiMDfB7AQ5jOd83XCxW6vRloWAOi0q+rDeO/Oqvm0yxmSC4IUoKPPAvE Iymo6WiPfELOkMpuKv8ElK0A1vfFLcPiNFwJCCVaj6AhWIvA4XTrPx43o/UfbA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678112713; a=rsa-sha256; cv=none; b=ykrY4ZVDUFhfIAKArKwaQqvcWomGCLBBKkGrFMJn2y/FEiwImAhCuAluQ8BALYdpLPkNBg IRPAQr8ocS8sKwU6hpbHzRB8KikN+9qFkPg71ZSmKcBI5p7j2k78aV42Rg8D0r9gAmON4Z YanRjbrztfwzNcjmM7YU3B88v0tYDPli0sRM/htZZkvOudRpLykBrzAVerGKiyJehm8LuY HVBMfAlnw6p3Xt+S8NyrBuOvCmyVGZVR3bfn51j7/gkK9Hoo7JtyBP01K+J5HNLVODjax3 73tF2eYmF5lK1QAnYe6AzRdo8Jrr4Jxxqb4tA+9unp1VgFnoClwx3g4398uhnQ== Received: from icepick.vmeta.jp (unknown [IPv6:2403:bd80:c100:411:e10f:5f62:d735:93a1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PVgpH2k1rz1793; Mon, 6 Mar 2023 14:25:11 +0000 (UTC) (envelope-from meta@FreeBSD.org) Date: Mon, 6 Mar 2023 23:25:06 +0900 From: Koichiro Iwao To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> X-Operating-System: FreeBSD 13.2-STABLE amd64 References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote: > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote: > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff > > > > security/softether5: add DEBUG option > > > > [...] > > +.include > > + > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk > > +# just set WITH_DEBUG=yes, CMAKE_ARGS+=-DCMAKE_BUILD_TYPE=Debug takes no effect. > > +.if ${PORT_OPTIONS:MDEBUG} > > +WITH_DEBUG= yes > > We do not expose this via options. To build debug package, just > "make -DWITH_DEBUG", don't ask users to fiddle with options. > > ./danfe Really? What's the difference exposing ports vs not? -- meta