From owner-p4-projects  Thu Jun 13  9:48:41 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 607D837B43D; Thu, 13 Jun 2002 09:48:34 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 6AB0137B409
	for <perforce@freebsd.org>; Thu, 13 Jun 2002 09:48:33 -0700 (PDT)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g5DGiLB33869
	for perforce@freebsd.org; Thu, 13 Jun 2002 09:44:21 -0700 (PDT)
	(envelope-from green@freebsd.org)
Date: Thu, 13 Jun 2002 09:44:21 -0700 (PDT)
Message-Id: <200206131644.g5DGiLB33869@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to green@freebsd.org using -f
From: Brian Feldman <green@FreeBSD.org>
Subject: PERFORCE change 12831 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12831

Change 12831 by green@green_laptop_1 on 2002/06/13 09:44:08

	The zombie_thread_lock can't be a MTX_SPIN if you want to sleep with
	it held.

Affected files ...

... //depot/projects/kse/sys/kern/kern_thread.c#66 edit

Differences ...

==== //depot/projects/kse/sys/kern/kern_thread.c#66 (text+ko) ====

@@ -75,7 +75,7 @@
 tdlist_head_t zombie_threads = TAILQ_HEAD_INITIALIZER(zombie_threads);
 struct mtx zombie_thread_lock;
 MTX_SYSINIT(zombie_thread_lock, &zombie_thread_lock,
-    "zombie_thread_lock", MTX_SPIN);
+    "zombie_thread_lock", MTX_DEF);
 
 /*
  * Pepare a thread for use.
@@ -241,9 +241,9 @@
 void
 thread_stash(struct thread *td)
 {
-	mtx_lock_spin(&zombie_thread_lock);
+	mtx_lock(&zombie_thread_lock);
 	TAILQ_INSERT_HEAD(&zombie_threads, td, td_runq);
-	mtx_unlock_spin(&zombie_thread_lock);
+	mtx_unlock(&zombie_thread_lock);
 }
 
 /* 
@@ -254,7 +254,7 @@
 {
 	struct thread *td_reaped, *td_next;
 
-	mtx_lock_spin(&zombie_thread_lock);
+	mtx_lock(&zombie_thread_lock);
 	td_reaped = TAILQ_FIRST(&zombie_threads);
 	while (td_reaped) {
 		td_next = TAILQ_NEXT(td_reaped, td_runq);
@@ -262,7 +262,7 @@
 		thread_free(td_reaped);
 		td_reaped = td_next;
 	}
-	mtx_unlock_spin(&zombie_thread_lock);
+	mtx_unlock(&zombie_thread_lock);
 	
 }
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message