From owner-cvs-all@FreeBSD.ORG Tue Jun 19 22:16:29 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 155C616A46B for ; Tue, 19 Jun 2007 22:16:29 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id EA1FE13C489 for ; Tue, 19 Jun 2007 22:16:28 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 61507 invoked from network); 19 Jun 2007 18:50:19 -0000 Received: from ppp-71-139-42-13.dsl.snfc21.pacbell.net (HELO ?10.0.0.15?) (nate-mail@71.139.42.13) by root.org with ESMTPA; 19 Jun 2007 18:50:19 -0000 Message-ID: <46782564.70700@root.org> Date: Tue, 19 Jun 2007 11:50:12 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.0 (X11/20070511) MIME-Version: 1.0 To: Kris Kennaway References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> <1182268273.23264.3.camel@erwin.int.cokane.org> <1182268443.21730.75.camel@pav.hide.vol.cz> <1182276521.23264.6.camel@erwin.int.cokane.org> <20070619184124.GA96145@rot13.obsecurity.org> In-Reply-To: <20070619184124.GA96145@rot13.obsecurity.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, pav@FreeBSD.org, cvs-all@FreeBSD.org, Coleman Kane , src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2007 22:16:29 -0000 Kris Kennaway wrote: > On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote: >> On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote: >>> Coleman Kane p????e v ??t 19. 06. 2007 v 11:51 -0400: >>>> On Mon, 2007-06-18 at 22:49 +0000, Pav Lucistnik wrote: >>>>> pav 2007-06-18 22:49:13 UTC >>>>> >>>>> FreeBSD src repository (doc,ports committer) >>>>> >>>>> Modified files: >>>>> usr.sbin/pkg_install/lib deps.c >>>>> Log: >>>>> - Replace rather inefficient bubble sort with a recursive depth-first search. >>>>> This speeds up registration of packages considerably. >>>>> - style(9) police welcome! >>>>> >>>>> PR: bin/112630 >>>>> Submitted by: Stephen Montgomery-Smith >>>>> Tested by: bento i386 experimental run >>>>> MFC after: 14 days >>>>> >>>>> Revision Changes Path >>>>> 1.12 +111 -65 src/usr.sbin/pkg_install/lib/deps.c >>>>> >>>> Is this by any chance connected to why many of my gnome2 dependencies >>>> would take longer to register than to compile? >>> Are you observing slowdown registering ports with this patch? >>> >> I don't think so. I don't even know if I have the latest sources for >> pkg_install down yet. >> >> I was actually referring to my experience since the x.org modularization >> that ended up (I think) causing so many dependencies on some packages >> that registration was awfully slow. I wanted to know if this patch was >> expected to fix that problem. > > Yes, precisely so. Excellent! Thanks for working on this, Pav. -- Nate