From owner-svn-src-all@freebsd.org Wed Feb 3 17:52:47 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09AB1A9777F for ; Wed, 3 Feb 2016 17:52:47 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm44-vm3.bullet.mail.bf1.yahoo.com (nm44-vm3.bullet.mail.bf1.yahoo.com [216.109.114.254]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AD8AECC for ; Wed, 3 Feb 2016 17:52:46 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1454521959; bh=apMBUSl+LVlJ3e3CrYKA+FmGhlirLagcwNrdFpH/iyI=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=tgepzLfICW0XiTeTBoEuuJCdWPpfUBNoQqtCNlKON2NVq2dPAjmXyNjYnEjteoEFlfMlKmhCNH37SyDK/C9QkuXAy0SeuR7NbtC5TmWQh4SxdkVwSwKJ+FvkqgaEtwYnrUdhlC4GLmGcjsoH1ySIBrR89MI5yQJm3Bn9836Aj7o3tQdYAsTCyC7sLe+o3nbZV8iLj9afRI84DIRQhjJwU9oZdiGJF+lY1hVKGdp8/NeLW11v5t9jk0OfUf+qbtw8d6yXHU+6YYeRAIWq2/skNLMM3XVvH3+1lzyDhbZJLwRbv68r88/wZ+5ZV7nG/xRLnXDlEr2mgMBjR+jSCLDkgQ== Received: from [98.139.170.179] by nm44.bullet.mail.bf1.yahoo.com with NNFMP; 03 Feb 2016 17:52:39 -0000 Received: from [98.139.213.13] by tm22.bullet.mail.bf1.yahoo.com with NNFMP; 03 Feb 2016 17:52:39 -0000 Received: from [127.0.0.1] by smtp113.mail.bf1.yahoo.com with NNFMP; 03 Feb 2016 17:52:39 -0000 X-Yahoo-Newman-Id: 547531.64459.bm@smtp113.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 2CCt7uAVM1l0FO5WH_RtXhQjw0.sL28UB9GqmUODDNX7smT 45PVOot4BdmSAEbjWCv2hGEzGFFk0tP2y9eOlZCYhRiOdXJoFLQ7TjYQeYBN .W2X.sTp1I.WT6Olt7CvP5yhDesohNf73AmysUwPUvaUmu8yc1jaY9N35FMm Z6AVZZ00Ot2qOXEn3DvMIzjameS1P6cjRZA0p6DYjmIPOEYj0Pd2JYgTsOPa wqv6XMOukEpUE7xpHs9w2asCef13HAAf5mWnoVhblCSXnYrSELnAkNEoo20Y 1mxFmFSCPLyNGT3YkDMqVRdWi3YLIDAoR5s7t2VXxlb_GuPdGDTBI8i1JfUu MOnNELZb05FWAbqx3oizsnkGlD7PpioBOlHybZZP75vjllGfDZNXM5eMXBI1 PkuhPiJ9RMXHkKbo1suE0IrwEmf4tbwqzak9v944OjB2OV4MUCXk3mE1nBOJ akVcJpa8zlyObBH7B_vGL4duExBXBwIfhJ3kxV8wy9Pj0FVk6v57ZVgv_mqV RQrjGyQLx74C1CVHjJn9pnFmbleyITFwS X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r295209 - head/sys/fs/ext2fs To: cem@FreeBSD.org References: <201602031431.u13EVNaL074412@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <56B23E69.5050006@FreeBSD.org> Date: Wed, 3 Feb 2016 12:52:41 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 17:52:47 -0000 On 02/03/16 12:38, Conrad Meyer wrote: > On Wed, Feb 3, 2016 at 6:31 AM, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Wed Feb 3 14:31:23 2016 >> New Revision: 295209 >> URL: https://svnweb.freebsd.org/changeset/base/295209 >> >> Log: >> Revert r294695: >> ext2fs: passthrough any extra timestamps to the dinode struct. >> >> While it passed the classic testing, the change appears to have >> caused some regression and still requires some more precautions. >> >> PR: 206820 > > What's the classic testing — xfstests or something more/less thorough? > My regular testing is fsx and then build a port (cad/spice) on it. Other people have been running other tests like pho's testsuite so we usually catch anything. > I was going to ask what the regression was, but then I noticed the PR number. > Yeah, the error is related to the inode size: I only tested the default (256) which has no problems. Considering the upcoming release I just want to get the get this reverted and I'll worry about a real fix later. Pedro.