From nobody Tue Apr 4 19:50:10 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Prddv5r4dz4450r; Tue, 4 Apr 2023 19:50:11 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Prddv5Lh7z4L1M; Tue, 4 Apr 2023 19:50:11 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oi1-x231.google.com with SMTP id b19so25080827oib.7; Tue, 04 Apr 2023 12:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680637810; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MBr5wPt8lXqeKmNOoqX7nuQyANuXuoo/iiXphqOwULQ=; b=Xz8HJz+lKA4jyKqUk8tuCRNXgdWMVEAvSCEdCjWXzJlqN1EZtbfXpi0mZZIj0v1fJ4 Mg/e7BdvMGp7vB7M6ewVQSBur3U3exR+ioCAmLZGf84aSgQVODbfpEBcriKznnhpQk+y /Sy+GZMAeww3zVKCtVMDue892PhNb2Vg8+HaT1dNPNiWaLvM5Q4ZhG+A7oxat9gf37ar aVxKFZ6z56j/4cJUKtjplRi1bTn9aTz91OoeggLaEKKozZ7U1qfpZANS12eeR4Vqa5Fl Ux2g9Ns3B81RUCW9RF/rvDp3st2l22qHlWOdgogPfcbJLBjODDlo7xFZvpRQvupdved5 Vsfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680637810; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MBr5wPt8lXqeKmNOoqX7nuQyANuXuoo/iiXphqOwULQ=; b=zHEAMnfOTd8IoacXSoHTIWu7XE5q2SUESjhsdXxYMVK/Dd0N8KPQ+l3myvSiWI4biL pjb8NUy+Dcx53W6aiA3NwgtYARywvDTJ9hIJ3ItIYWdT0HMsb/3XmR1cduHaYA0HGyJI wbnigce4nJVCzg2UNVZiK2AwAH+J0myOkUHGFc84PtRLRR55Cole8VEmfo/UCvGw0TNq wJzur/9eJSmfhyTG8Q43GAi5OhZrdezrxQ5wQrvC6IelAm2H6deTVosN0tQSGBPQ9k6T zqlLC+iAvBsFLR2tw4xiU5BenA5eFtFO6STGd9OAuPIYSPt0wnGrSsThMTNATs+qMOa0 1S/w== X-Gm-Message-State: AAQBX9e8j0y/DtzWfs8Q1XpRBJ9rzrTwL2VcbcEKduarKu5PeCptHFcr 7PUF4jAP4fvRS2hNNDDqrfW0FpRKH4UkVSX2acw= X-Google-Smtp-Source: AKy350bnLnzjfGDWUi7QmTGskRoKD/5Pl+2M8QlRNz9GzwF2Y3l2YJhlE5ZpQ4Jb3WHP42Dq3PpQY7oupCMoegA2AKk= X-Received: by 2002:a05:6808:2009:b0:386:d8a5:d80b with SMTP id q9-20020a056808200900b00386d8a5d80bmr907749oiw.4.1680637810787; Tue, 04 Apr 2023 12:50:10 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Received: by 2002:a8a:791:0:b0:49c:b071:b1e3 with HTTP; Tue, 4 Apr 2023 12:50:10 -0700 (PDT) In-Reply-To: <20230404124846.576d26fd@slippy> References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> <5B7F71CC-5BE6-4938-A29E-E10B01A4E4ED@panasas.com> <20230404123054.6cf5fb6b@slippy> <20230404124846.576d26fd@slippy> From: Mateusz Guzik Date: Tue, 4 Apr 2023 21:50:10 +0200 Message-ID: Subject: Re: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled To: Cy Schubert Cc: "Pokala, Ravi" , Martin Matuska , Rick Macklem , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Prddv5Lh7z4L1M X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 4/4/23, Cy Schubert wrote: > On Tue, 4 Apr 2023 12:30:54 -0700 > Cy Schubert wrote: > >> On Tue, 4 Apr 2023 17:54:28 +0000 >> "Pokala, Ravi" wrote: >> >> > Cy, >> > >> > The patch adds 'bool done_outvp', unconditionally sets it to 'true', and >> > then later has a check for 'if (!done_outvp)'. Since there is no >> > intervening place where 'done_outvp' could be set to 'false', that check >> > will never succeed and that branch is unreachable. >> >> It's set to false at line 6454, in the loop locking vnodes. >> >> > >> > Or am I mis-reading something? >> >> Maybe Rick can explain but all we're doing is ensuring that the first >> part of the loop is executed only first time through. We could invert it >> and save setting it to false every loop. > > No. Looking at it more closely, I was wrong. What Rick is doing is > probably the best approach. > >> >> > >> > Thanks, >> > >> > Ravi (rpokala@) >> > >> > > I'll try to put together a review tonight. Having said that, I don't > want to take the credit for this "final" fix. We have Martin and Rick > to thank for doing the heavy lifting. > > massaging names for the commit is not a problem -- Mateusz Guzik