Date: Mon, 24 Jun 2019 22:27:03 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: "Tobias C. Berner" <tcberner@gmail.com> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505045 - head/sysutils/plasma5-ksysguard Message-ID: <20190624202703.GA68048@ThinkPad-X200.g.anongoth.pl> In-Reply-To: <CAOshKtegUmUYfdnDNmt9wuk1cSC_z_qpz8td597zC4y3Dup_-w@mail.gmail.com> References: <201906241810.x5OIAu1h080487@repo.freebsd.org> <CAOshKtcPHHa4%2Bv2kL_aNKXzoXs1VkGw0nEAx3PkaArPJ6kCGzw@mail.gmail.com> <20190624194627.GB49520@ThinkPad-X200.g.anongoth.pl> <CAOshKtegUmUYfdnDNmt9wuk1cSC_z_qpz8td597zC4y3Dup_-w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZZyDjIJw6poXyVBU Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable OK, for me maintainer-feedback entry means that the patch is accepted. When I wasn't a committer, I used to set maintainer-feedback to indicate th= at I accept the patch. When I send PR's nowadays, some maintainers also do = that. On 19-06-24 21:54:56, Tobias C. Berner wrote: >I set maintainer feedback, because I, as the maintainer gave you the >feedback, that "I think this is wrong" :) >If I liked that patch, I would have set the patch-approved flag on it. > > >All that said, thanks for "fixing" it, but I still would prefer a real fix, >that we can upstream rather than that. > > >mfg Tobias > > >On Mon, 24 Jun 2019 at 21:46, Piotr Kubaj <pkubaj@anongoth.pl> wrote: > >> Oh, I didn't use "implicit". Doesn't maintainer-feedback + mean that it's >> accepted? >> >> On 19-06-24 21:34:09, Tobias C. Berner wrote: >> >Moin moin >> > >> >Sorry, but I explicitely did not approve this :) so using implicit on i= t, >> >is a bit of a crappy move. >> > >> >mfg Tobias >> > >> >On Mon, 24 Jun 2019 at 20:11, Piotr Kubaj <pkubaj@freebsd.org> wrote: >> > >> >> Author: pkubaj >> >> Date: Mon Jun 24 18:10:55 2019 >> >> New Revision: 505045 >> >> URL: https://svnweb.freebsd.org/changeset/ports/505045 >> >> >> >> Log: >> >> sysutils/plasma5-ksysguard: fix build with GCC-based architectures >> >> >> >> Link with libinotify explicitly to fix linking on GCC architectures. >> >> >> >> PR: 238702 >> >> Approved by: tcberner (maintainer, mentor) >> >> >> >> Modified: >> >> head/sysutils/plasma5-ksysguard/Makefile >> >> >> >> Modified: head/sysutils/plasma5-ksysguard/Makefile >> >> >> >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> >> --- head/sysutils/plasma5-ksysguard/Makefile Mon Jun 24 18:07:12 2= 019 >> >> (r505044) >> >> +++ head/sysutils/plasma5-ksysguard/Makefile Mon Jun 24 18:10:55 2= 019 >> >> (r505045) >> >> @@ -23,5 +23,6 @@ OPTIONS_SUB=3D yes >> >> >> >> INOTIFY_DESC=3D Filesystem alteration notifications using >> inotify >> >> INOTIFY_LIB_DEPENDS=3D libinotify.so:devel/libinotify >> >> +INOTIFY_LDFLAGS=3D -linotify >> >> >> >> .include <bsd.port.mk> >> >> >> >> >> > >> >-- >> >This message has been scanned for viruses and >> >dangerous content by MailScanner, and is >> >believed to be clean. >> > >> > >--=20 >This message has been scanned for viruses and >dangerous content by MailScanner, and is >believed to be clean. > --ZZyDjIJw6poXyVBU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl0RMhdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM5 Q0M4ODc4RDkyNDgyODg3M0IyOEEyQjdBNTk5Qjg1MjA4MzlDOUQACgkQelmbhSCD nJ1lIhAAgD+CiXowN8UvDNQJf5Y0P3224/hVHkvr07QtAkvuPP9eNEEFj655w4Oy 5Yhx8t2wRuR/lo5htxxj37N5O61NvjUPqxoBkdnD8hZyV0Krv8JGuGrLk1Ufi8Bb qVdX8DVHeBLZ5iQH9obdBFLYBe3D4JrYgVZ8NgsDCr7njpP+Q0beNWms4xUyrvbw 1Jv9A2FqkTtGGqPCqpHMXqGCf++SXzDonsiV8Szww18vliySea2iJytCKgX/xzcj mETaUs8u2K5IOwckndpiMcNLt+RGnSWOxFbs3l0yspJau3B7ZAvz8z6JyNkgrxJ7 I8+xluS44sDC/XzezrfCG6fu7gK4a3VKgx2pWzQHDxl48DamA40wvzTAh/01ZaZu UzQaho/NpHFP3ioLDnL7DfmxkaPM86KhG0C5F4FhyUfi5vcC/Js6aboTUICCVuiG qUTgU8i2G0UjICYnlwo8W3iR/9bSEBHMw+OVbA9Zccfq7WzKcjkJQH/u0YpThllJ OfgFIkdFGVCBX+ii+NqxbRdBhZogoVpfMkzWx/3deTwHYm+1gDrQWvUP9HRI2uLQ gF+G8aeiuFgKdwztE1i6qeDql6PXjj2BjeaB4Iy3kJBwIu0QvhQFTs/Xrk7RpDsH 6AlANjRvrQhMyHkcpFfRfWjhSKr/07qdItlY2uHdIllhvd4Ce40= =OdEb -----END PGP SIGNATURE----- --ZZyDjIJw6poXyVBU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190624202703.GA68048>