From nobody Wed Jul 15 21:27:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h0q5F0dbwz6m34L for ; Wed, 15 Jul 2026 21:27:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h0q5D5l6Jz3R6d for ; Wed, 15 Jul 2026 21:27:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784150848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cyqsAe+g5Qf0VtRavsOz9hcEwh+fioNjGeWRMXNd784=; b=wOSBQmOH3qRdUAX/2EE38eKqv24VDVH/jjk6PQYh79ty1JGHbr6IzcHu9k1NiNGeF9IcAk q3ZFCaeZ2UCIye0nDqQH/ViZ+uXpI/8cXVE41EnpHdjYgI9IjjNqNQeXxL7u66gQeKj9EY G8FdxrVHGSD/rVoT8W0Ooh4o6mbBGQ2xaR7ai5UuoD19+fnktdYrQlrz9TstQItNATk9Oe F3vENC6A8sfG4wPFgcHENJo2ATTS7C7IjY0mMhuCicRDITBK/b0543vYiY+rppl9fy7/gg 1lrE3FgfpyS48aOzioZpiKNNkHOFC/S4kr4qyGE5JeUWNeIqG4I+QAuzXRVoKQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784150848; a=rsa-sha256; cv=none; b=Tt2be6Oxf7X+uBWGNW3ICAT5oc62vu0s8rwDV1KHw+M6lAkzrY3RULPajZXWCLV88HpQbb FWWKDcUAQlyTy1fG4m0xh2+UweI6QZD7H2bF/awF+NUShD5DgM2p1EuyuxldpRqdfZSJzq anEiAvpE3rt5aahcu9z2OzYejQigLVTaOPjVEmsC6jXpeH/MjKbW6rux28jglKG1mKnbOZ Gpwp0gPcwAUXdKNTbp5GT1VMgzsSosKtbWLbudEzRnvffG6BbCx9B122jQ9DU7EYUY1VH2 O1oF/CnQEPjunV+u4iq4alfna9dBgbdqznmfHzmqaLUxBooOsnFqSW6K7XqlpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784150848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cyqsAe+g5Qf0VtRavsOz9hcEwh+fioNjGeWRMXNd784=; b=gwhPoYufj2xoIBfNT6nnVmBVxzdfw+yzvYnczWwIzypYCf7e1+Q/vd8FmCJhnh2Bt0RbRw tQIdiAiGBl814LJLYKkJkamihgHrtUAQP+U2jBpA9Ifw7AzvUOWO1ZjY4fUVwheghmKJfL 7mEDIst2sAGCfofvR0C620zsjR9KS17xFD8ccKs8adiN1/wFEdUTpzW3Danr+ylzKe2x5R Wjo13s4c8Jd6XPk2xPDQTT07pqyw8BeTMSpNG2dx+G03iuf20eLXCe1tg9CpYc1tIzc7JI zTtnsAPvVx01lWt/65eSxutqzQpJ+VjoxsE58eI7MdHZWhb8AfV1dp8kJXVIDg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h0q5D4ZvZzp3D for ; Wed, 15 Jul 2026 21:27:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19501 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 15 Jul 2026 21:27:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 664ad9ac4c90 - main - acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 664ad9ac4c9047d29d5f37d43174e1b469e2ec80 Auto-Submitted: auto-generated Date: Wed, 15 Jul 2026 21:27:23 +0000 Message-Id: <6a57fb3b.19501.3a3766d7@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=664ad9ac4c9047d29d5f37d43174e1b469e2ec80 commit 664ad9ac4c9047d29d5f37d43174e1b469e2ec80 Author: Olivier Certner AuthorDate: 2026-07-07 13:34:21 +0000 Commit: Olivier Certner CommitDate: 2026-07-15 21:26:47 +0000 acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable This is to prevent child drivers from using the features returned by previous drivers (in an arbitrary order). None of the existing ones do that, so this is purely defensive. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation --- sys/dev/acpica/acpi_cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi_cpu.c b/sys/dev/acpica/acpi_cpu.c index d2358f7077e5..48f6a27c1e89 100644 --- a/sys/dev/acpica/acpi_cpu.c +++ b/sys/dev/acpica/acpi_cpu.c @@ -313,7 +313,6 @@ acpi_cpu_attach(device_t dev) struct acpi_cpu_softc *sc; struct acpi_softc *acpi_sc; ACPI_STATUS status; - u_int features; int cpu_id, drv_count, i; driver_t **drivers; uint32_t cap_set[3]; @@ -417,6 +416,8 @@ acpi_cpu_attach(device_t dev) if (devclass_get_drivers(device_get_devclass(dev), &drivers, &drv_count) == 0) { for (i = 0; i < drv_count; i++) { + u_int features = 0; + if (ACPI_GET_FEATURES(drivers[i], &features) == 0) sc->cpu_features |= features; }