Date: Tue, 04 Sep 2012 13:41:56 +0200 From: Florian Smeets <flo@smeets.im> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303626 - head/www/xpi-firebug Message-ID: <5045E904.5080608@smeets.im> In-Reply-To: <50457770.4060402@FreeBSD.org> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/04/2012 05:37, Doug Barton wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 09/03/2012 16:51, Florian Smeets wrote: > >> So I reread the complete thread (r301039 and followups) again, the >> only problem there seems to be is pchecker complaining, > > It's a problem for anything that uses 'while read ...' to process > those files, including portmaster. > > If you have the list of files with this problem and aren't interested > in fixing them, pass the list along and I'll do it. > First of all, Doug thank you for fixing all of these. I should probably have included the list of files, it was almost 2AM so I might have been a bit sleepy already :) I still see this as a style nit. Can you be a bit more specific where portmaster fails with distinfo (or other files) not having the last newline? It works just fine for me in that case. I'm really trying to understand if something actually breaks. I've also asked Shaun if he's aware of that problem and if he can give hints on fixing this, so we won't have to keep fixing these or at least eliminate one source of this problem. Thanks, Florian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5045E904.5080608>