Date: Thu, 13 Feb 2003 14:17:29 -0800 From: Peter Wemm <peter@wemm.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Marcel Moolenaar <marcel@xcllnt.net>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile Message-ID: <20030213221729.DD3D32A8C1@canning.wemm.org> In-Reply-To: <xzpwuk3suq3.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav wrote: > Marcel Moolenaar <marcel@xcllnt.net> writes: > > On Thu, Feb 13, 2003 at 10:41:52PM +0100, Dag-Erling Smorgrav wrote: > > > Peter Wemm <peter@FreeBSD.org> writes: > > > > We only provide agp drivers for the intel chipsets, move the agp > > > > subdir to the i386-only section. > > > Some Alphas have AGP slots. > > As do ia64 calculators. Even HP's zx1 based calculators have AGP. > > None of them are supported by us I think, but that's a different > > story. > > My point is that the agp module used to build and load fine on Alpha > (though I don't know if it worked, as my PWS doesn't have an AGP > slot). Then Eric commits a patch which broke Alpha support, and > instead of trying to rectify the problem with a few well-placed > #ifdefs, Peter just yanks it from the Alpha build. Is that really the > way to go? It was broken on everything. /vol/vol0/users/des/tinderbox/CURRENT/sparc64/sparc64/src/sys/pci/ \ agp_i810.c:353: `AGP_I855_GCC1_GMS_STOLEN_16M' undeclared (first use in this function) sys/pci-142> grep AGP_I855_GCC1_GMS_STOLEN_16M * agp_i810.c: case AGP_I855_GCC1_GMS_STOLEN_16M: agpreg.h:#define AGP_I855_GCC1_GMS_STOLEN_16M 0x40 The lines in agpreg.h were what Eric added after the fact. This is an i386-only chipset. It shouldn't have been in the sparc64, ia64, and alpha builds. It certainly shouldn't be in powerpc whenever we start doing builds for that. And IMHO, we certainly shouldn't be building/installing/releasing something that we *know* hard locks the machine (Drew's report on agp_amd.c locking up the UP1000). Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030213221729.DD3D32A8C1>