From owner-freebsd-security@FreeBSD.ORG Tue Jun 20 20:24:45 2006 Return-Path: X-Original-To: freebsd-security@FreeBSD.org Delivered-To: freebsd-security@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFE1516A474; Tue, 20 Jun 2006 20:24:44 +0000 (UTC) (envelope-from keramida@FreeBSD.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 164E543D45; Tue, 20 Jun 2006 20:24:43 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from gothmog.pc (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.7/8.13.7/Debian-1) with ESMTP id k5KKOVoR003486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 20 Jun 2006 23:24:32 +0300 Received: from gothmog.pc (gothmog [127.0.0.1]) by gothmog.pc (8.13.6/8.13.6) with ESMTP id k5KKOO6G011576; Tue, 20 Jun 2006 23:24:24 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from giorgos@localhost) by gothmog.pc (8.13.6/8.13.6/Submit) id k5KKOOl9011575; Tue, 20 Jun 2006 23:24:24 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Tue, 20 Jun 2006 23:24:24 +0300 From: Giorgos Keramidas To: Jason Evans , Dan Lukes Message-ID: <20060620202424.GB11347@gothmog.pc> References: <44980ECC.5000607@obluda.cz> <20060620170353.GB90842@gothmog.pc> <449833DD.70904@FreeBSD.org> <44984A25.8060001@obluda.cz> <20060618203903.31161.qmail@web30306.mail.mud.yahoo.com> <44967861.6070509@obluda.cz> <20060620125350.10d0c9ef.nick@nickwithers.com> <44980ECC.5000607@obluda.cz> <20060620170353.GB90842@gothmog.pc> <449833DD.70904@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44985028.6020901@FreeBSD.org> <44984A25.8060001@obluda.cz> <449833DD.70904@FreeBSD.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-4.235, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.16, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No X-Mailman-Approved-At: Wed, 21 Jun 2006 02:01:20 +0000 Cc: freebsd-security@FreeBSD.org Subject: Re: memory pages nulling when releasing X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2006 20:24:45 -0000 On 2006-06-20 10:43, Jason Evans wrote: >Giorgos Keramidas wrote: >>On 2006-06-20 17:05, Dan Lukes wrote: >>>BTW, Z nor J doesn't imply 'R' despite of text of manual page. >> >> Are you sure? Then we should fix the manpage. >> Cc'ing Jason Evans, who may be interested too. > > The man page looks accurate to me. What aspect of the descriptions of > 'J' and 'Z' do you think is incorrect? On 2006-06-20 21:19, Dan Lukes wrote: > From manual page: > ======================= > J ... > This options also sets the ``R'' option. > ... > Z This option implicitly sets the ``J'' and ``R'' options, > ======================= > > > From libc/stdlib/malloc.c (the lines containing malloc_realloc + > some lines around) > ======================= > static int malloc_realloc; > ... > case 'r': malloc_realloc = 0; break; > case 'R': malloc_realloc = 1; break; > case 'j': malloc_junk = 0; break; > ... > if (!malloc_realloc && /* Unless we have > to, */ > size <= osize && /* .. or are too small, ... > if (!malloc_realloc && /* Unless we have to, */ > size <= osize && /* ..or are too small, */ > ======================= > > The malloc_realloc seems to be set on one place only - when R/r > present. Then it is used only. I see no dependency to J nor Z > > I send no PR because I have submitted several more important PR's > which are untouched for months. I don't want to overload committers > nor PR database. No, that's ok. It's better to send what you have found so it won't be missed forever :-) On 2006-06-20 12:44, Jason Evans wrote: > Ah, this is for RELENG_6. I had assumed you were talking about > -current. I agree with you that the man page is inaccurate for > RELENG_6. I don't currently use RELENG_6 for development though, so > I'd recommend submitting a PR with a patch assigned to the docs folks > if you want it fixed. In my experience they are very responsive where > man page accuracy is concerned. Sure! Dan, if you submit a PR, then feel free to include my own address at the Cc: line of send-pr's report. Then I'll grab the PR and work through the necessary changes for RELENG_6 with you. Thanks for bringing this manpage bug to our attention :) - Giorgos