From owner-freebsd-rc@FreeBSD.ORG Tue Mar 27 17:34:34 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C290106564A; Tue, 27 Mar 2012 17:34:34 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id 496A88FC08; Tue, 27 Mar 2012 17:34:33 +0000 (UTC) Received: from mail.dw.redsrci.com (localhost [127.0.0.1]) by mail.dw.redsrci.com (Postfix) with ESMTP id 494946F30DA; Tue, 27 Mar 2012 10:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= experts-exchange.com; h=message-id:date:date:from:from:subject :subject:received:received:received; s=ee; t=1332869200; x= 1334683600; bh=pVZprJB6BcYDMr6P4qd8AdoXqMpGOEf2bv4nhrCPpJg=; b=C a86PekHKHsfFJj3VD0blWD2C5L0LB1PpU7L9iZeqTbH/yC6Wq3eUi4+dSqpaUI8t /nkk+7msE0Uhj3KqTo1I1Wvuj9A2UdN8BrDz33xdeyutvMku8Em9sq5r205Tl2+R CjfynabPF0b/OoH3gbuxMux3atP3DV86R2rN0TCOlQ= X-Virus-Scanned: amavisd-new at experts-exchange.com Received: from mail.dw.redsrci.com ([127.0.0.1]) by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6bGYmgp1k-9; Tue, 27 Mar 2012 10:26:40 -0700 (PDT) Received: from experts-exchange.com (unknown [192.168.103.120]) by mail.dw.redsrci.com (Postfix) with SMTP id 21E466F30D3; Tue, 27 Mar 2012 10:26:40 -0700 (PDT) Received: (nullmailer pid 86669 invoked by uid 1001); Tue, 27 Mar 2012 17:25:46 -0000 To: FreeBSD-gnats-submit@freebsd.org From: Jason Helfman X-send-pr-version: 3.113 X-GNATS-Notify: Date: Tue, 27 Mar 2012 10:25:46 -0700 Message-Id: <1332869146.439481.86668.nullmailer@experts-exchange.com> Cc: 5u623l20@gmail.com, rc@freebsd.org Subject: [PATCH] www/resin3: reorganize rc script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2012 17:34:34 -0000 >Submitter-Id: current-users >Originator: Jason Helfman >Organization: >Confidential: no >Synopsis: [PATCH] www/resin3: reorganize rc script >Severity: non-critical >Priority: low >Category: ports >Class: change-request >Release: FreeBSD 8.2-RELEASE amd64 >Environment: System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011 >Description: Modifications were requested to the resin rc script from dougb@ I am putting this pr in for approval and review Added file(s): - files/resin3.in Removed file(s): - files/resin3.sh.in Port maintainer (5u623l20@gmail.com) is cc'd. Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS) >How-To-Repeat: >Fix: --- resin-3.1.12_1.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/www/resin3/Makefile,v retrieving revision 1.46 diff -u -r1.46 Makefile --- Makefile 14 Mar 2012 18:09:37 -0000 1.46 +++ Makefile 27 Mar 2012 17:24:38 -0000 @@ -7,6 +7,7 @@ PORTNAME= resin PORTVERSION= 3.1.12 +PORTREVISION= 1 CATEGORIES= www java MASTER_SITES= http://www.caucho.com/download/ @@ -44,7 +45,7 @@ # Other settings APXS?= ${LOCALBASE}/sbin/apxs SUB_FILES= pkg-message resin3ctl -USE_RC_SUBR= resin3.sh +USE_RC_SUBR= resin3 .include Index: files/resin3.in =================================================================== RCS file: files/resin3.in diff -N files/resin3.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/resin3.in 27 Mar 2012 17:24:38 -0000 @@ -0,0 +1,43 @@ +#!/bin/sh +# +# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 16:29:23 jgh Exp $ +# + +# PROVIDE: %%APP_NAME%% +# REQUIRE: LOGIN NETWORKING SERVERS +# BEFORE: DAEMON +# KEYWORD: shutdown + +# +# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: +# +# %%APP_NAME%%_enable="YES" +# + + +%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} +%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} +%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} + +. /etc/rc.subr + +name=%%APP_NAME%% +rcvar=%%APP_NAME%%_enable + +load_rc_config ${name} + +command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" +command_args="start" +pidfile=%%PID_FILE%% + +if test -n "${%%APP_NAME%%_java_version}" ; then + JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) + procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) +else + JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) + procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) +fi + +export JAVA_HOME + +run_rc_command "$1" Index: files/resin3.sh.in =================================================================== RCS file: files/resin3.sh.in diff -N files/resin3.sh.in --- files/resin3.sh.in 13 Mar 2012 16:29:23 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,43 +0,0 @@ -#!/bin/sh -# -# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 16:29:23 jgh Exp $ -# - -# PROVIDE: %%APP_NAME%% -# REQUIRE: LOGIN -# KEYWORD: shutdown - -# -# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: -# -# %%APP_NAME%%_enable="YES" -# - -. /etc/rc.subr - -name=%%APP_NAME%% -rcvar=%%APP_NAME%%_enable - -command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" -command_args="start" -pidfile=%%PID_FILE%% - -# set defaults - -%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} -%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} -%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} - -load_rc_config ${name} - -if test -n "${%%APP_NAME%%_java_version}" ; then - JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) - procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) -else - JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) - procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) -fi - -export JAVA_HOME - -run_rc_command "$1" --- resin-3.1.12_1.patch ends here ---