From owner-freebsd-acpi@FreeBSD.ORG Wed Jun 25 10:08:23 2014 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 73955F3C; Wed, 25 Jun 2014 10:08:23 +0000 (UTC) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AEF672390; Wed, 25 Jun 2014 10:08:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id s5PA8CQc063038; Wed, 25 Jun 2014 20:08:12 +1000 (EST) (envelope-from smithi@nimnet.asn.au) Date: Wed, 25 Jun 2014 20:08:11 +1000 (EST) From: Ian Smith To: John Baldwin Subject: Re: ACPI error messages on Lenovo W540 In-Reply-To: <201406241000.35812.jhb@freebsd.org> Message-ID: <20140625190106.N609@sola.nimnet.asn.au> References: <53A048B1.1080108@metricspace.net> <201406230953.16496.jhb@freebsd.org> <53A8AD54.8040908@metricspace.net> <201406241000.35812.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: freebsd-acpi@freebsd.org, freebsd-mobile@freebsd.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 10:08:23 -0000 On Tue, 24 Jun 2014 10:00:35 -0400, John Baldwin wrote: > On Monday, June 23, 2014 6:42:28 pm Eric McCorkle wrote: > > On 06/23/2014 09:53, John Baldwin wrote: > > > On Tuesday, June 17, 2014 9:54:57 am Eric McCorkle wrote: > > >> I suspect these might have something to do with the USB 3.0 system not > > >> working, though I don't have experience with either the ACPI or USB > > >> subsystems. > > > > > > Does it not work in general, or does it not work after resume? > > > > Actually, USB seems to be working quite well. It even detects an > > already plugged-in mouse during the ith resume. > > > > The sign of trouble are some messages that show up during resume: > > > > usb_alloc_device: device init 2 failed (USB_ERR_IOERROR, ignored) > > ugen0.2: at usbus2 (disconnected) > > uhub_reattach_port: could not allocate new device > > > > There had been some timeout messages, which googling seemed to implicate > > was a USB 3.0 issue with lenovos, but those seem to have disappeared (I > > did do a kernel update). > > > > Maybe I should test USB 3.0-specific features to see if they are > > working. Unfortunately, I'm not that familiar with the gritty details > > of USB. Any ideas for how to do that? > > There was a recent fix to acpi_pwrres.c that fixed USB issues on resume for > several ThinkPads because the kernel wasn't properly turning certain things > back on during resume, so if your problems were only with resume, then there's > a good chance they should now be fixed (and it sounds like they did after you > updated). Well, this is most timely for me; I was about to query you and hps@ for advice re debugging knobs to have another crack at debugging this issue! Not nearly content to wait for MFC, I applied the diff-to-previous from r267647 of /sys/dev/acpica/acpi_powerres.c to stable/9, which was clean, so I updated source, applied the patch and rebuilt world and kernel: FreeBSD x200.smithi.id.au 9.3-PRERELEASE FreeBSD 9.3-PRERELEASE #0: Wed Jun 25 15:29:28 EST 2014 root@x200.smithi.id.au:/usr/obj/usr/src/sys/GENERIC amd64 After which I suspended and resumed 5 times, to be quintuply sure, and yes, my 1GB SwissFlash stick - normally annoying because it has a very bright red LED that's always on when the port is powered - lit up every time, so the external USB ports losing power problem is fixed on mine. However, it loses touch with a mounted UFS partition on the stick after suspend/resume; I've never been sure if I should expect that to work? Even so, umount, fsck then remount fixes it, so now my X200 is actually usable in traveling-without-rebooting-for-weeks mode, so I'm happy and am passing on this good news for all(?) Lenovo Thinkpads to mobile@ too. Many thanks to you and trasz@, and I'm only slightly apologising for riding alongside Eric's other video problem .. cheers, Ian