From owner-svn-src-all@FreeBSD.ORG Thu Dec 13 11:11:13 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1028D119; Thu, 13 Dec 2012 11:11:13 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id C002D8FC0A; Thu, 13 Dec 2012 11:11:12 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id DC8C632A; Thu, 13 Dec 2012 12:09:08 +0100 (CET) Date: Thu, 13 Dec 2012 12:12:44 +0100 From: Pawel Jakub Dawidek To: Konstantin Belousov Subject: Re: svn commit: r244154 - head/bin/ps Message-ID: <20121213111240.GB1381@garage.freebsd.pl> References: <201212121545.qBCFj4Hl086444@svn.freebsd.org> <20121212210652.GO3013@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jho1yZJdad60DJr+" Content-Disposition: inline In-Reply-To: <20121212210652.GO3013@kib.kiev.ua> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, jhb@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2012 11:11:13 -0000 --jho1yZJdad60DJr+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > On Wed, Dec 12, 2012 at 03:45:04PM +0000, Pawel Jakub Dawidek wrote: > > Author: pjd > > Date: Wed Dec 12 15:45:03 2012 > > New Revision: 244154 > > URL: http://svnweb.freebsd.org/changeset/base/244154 > >=20 > > Log: > > Use kern.max_pid sysctl to obtain maximum PID number instead of using= local > > define. > It is pid_max, not max_pid. >=20 > But the change is wrong. The kern.pid_max only limits newly allocated pid= s, > it does not magically moves existing pids, which are out of range, to the > limited region. See the corresponding commit log for the description. > It was added to make it easier to run FreeBSD 1.x binaries on the modern > kernels. I saw CTLFLAG_TUN on the sysctl and assumed it is read-only... How about defining BSD_PID_MAX in sys/proc.h, which would be visible by userland as well and setting PID_MAX to BSD_PID_MAX? This would also help bsnmpd. http://people.freebsd.org/~pjd/patches/PID_MAX.patch --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --jho1yZJdad60DJr+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDJuCgACgkQForvXbEpPzRgjwCg5aK3VpBBR4HjVyIAa37Pbu0C F3YAoKEH8BTD4QmtCIMn7J22qBqhQF8/ =uiYE -----END PGP SIGNATURE----- --jho1yZJdad60DJr+--