Date: Mon, 4 Jun 2018 17:00:22 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Piotr Pawel Stefaniak <pstef@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334630 - head/usr.bin/indent Message-ID: <201806050000.w5500Men098070@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201806042024.w54KOWPt045801@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: pstef > Date: Mon Jun 4 20:24:31 2018 > New Revision: 334630 > URL: https://svnweb.freebsd.org/changeset/base/334630 > > Log: > indent(1): remove static const char copyright[] > > It repeats what is already said in the heading comment and it's optimized out > so serves no purpose. The purpose would be to put a copyright into the binary, and why that is not happening when the original authors intended that is not good. This is a regression, as 5.4p8 shows: {108}% strings /usr/bin/indent | grep -i copy bcopy @(#) Copyright (c) 1985 Sun Microsystems, Inc. @(#) Copyright (c) 1976 Board of Trustees of the University of Illinois. @(#) Copyright (c) 1980, 1993 Please walk very very very carefully around all things "copyright". > Modified: > head/usr.bin/indent/indent.c > > Modified: head/usr.bin/indent/indent.c > ============================================================================== > --- head/usr.bin/indent/indent.c Mon Jun 4 20:21:51 2018 (r334629) > +++ head/usr.bin/indent/indent.c Mon Jun 4 20:24:31 2018 (r334630) > @@ -35,14 +35,6 @@ > * SUCH DAMAGE. > */ > > -#ifndef lint > -static const char copyright[] = > -"@(#) Copyright (c) 1985 Sun Microsystems, Inc.\n\ > -@(#) Copyright (c) 1976 Board of Trustees of the University of Illinois.\n\ > -@(#) Copyright (c) 1980, 1993\n\ > - The Regents of the University of California. All rights reserved.\n"; > -#endif /* not lint */ > - > #if 0 > #ifndef lint > static char sccsid[] = "@(#)indent.c 5.17 (Berkeley) 6/7/93"; > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806050000.w5500Men098070>