From owner-svn-ports-all@freebsd.org Mon Oct 15 18:37:51 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F03510C44CD; Mon, 15 Oct 2018 18:37:51 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A0077FB56; Mon, 15 Oct 2018 18:37:51 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from mousie.catspoiler.org (unknown [76.212.85.177]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: truckman) by smtp.freebsd.org (Postfix) with ESMTPSA id 8813B1B22D; Mon, 15 Oct 2018 18:37:50 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Date: Mon, 15 Oct 2018 11:37:47 -0700 (PDT) From: Don Lewis Subject: Re: svn commit: r482164 - in head/editors: openoffice-4 openoffice-4/files openoffice-devel openoffice-devel/files To: Jan Beich cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org In-Reply-To: Message-ID: References: <201810151727.w9FHRg1Z083071@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 18:37:51 -0000 On 15 Oct, Jan Beich wrote: > Don Lewis writes: > >> ++ EVP_CIPHER_CTX *pAes_ctx; >> ++#if OPENSSL_VERSION_NUMBER < 0x10100000L >> + EVP_CIPHER_CTX aes_ctx; >> + EVP_CIPHER_CTX_init( &aes_ctx ); >> +- EVP_DecryptInit_ex( &aes_ctx, EVP_aes_128_ecb(), 0, pnKey, 0 ); >> +- EVP_CIPHER_CTX_set_padding( &aes_ctx, 0 ); >> ++ pAes_ctx = &aes_ctx; >> ++#else >> ++ pAes_ctx = EVP_CIPHER_CTX_new(); >> ++#endif >> ++ EVP_DecryptInit_ex( pAes_ctx, EVP_aes_128_ecb(), 0, pnKey, 0 ); >> ++ EVP_CIPHER_CTX_set_padding( pAes_ctx, 0 ); > > Why conditional? Also, LibreSSL still uses non-opaque structs. The older OpenSSL man page doesn't mention EVP_CIPHER_CTX_new(), so I assumed that it wasn't implemented. Nobody seems to have tried building OpenOffice with LibreSSL.