From owner-svn-src-all@FreeBSD.ORG Wed Mar 10 04:49:38 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6EB60106566B; Wed, 10 Mar 2010 04:49:38 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 4B5108FC15; Wed, 10 Mar 2010 04:49:38 +0000 (UTC) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.4/8.14.4) with ESMTP id o2A4nV0M011196; Tue, 9 Mar 2010 20:49:31 -0800 (PST) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.4/8.14.4/Submit) id o2A4nVFZ011195; Tue, 9 Mar 2010 20:49:31 -0800 (PST) (envelope-from obrien) Date: Tue, 9 Mar 2010 20:49:31 -0800 From: "David O'Brien" To: "M. Warner Losh" Message-ID: <20100310044931.GD96059@dragon.NUXI.org> References: <4B945CAC.9020706@FreeBSD.org> <20100310015551.GA12405@dragon.NUXI.org> <4B97030A.1040704@FreeBSD.org> <20100309.193512.775474398290078267.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100309.193512.775474398290078267.imp@bsdimp.com> X-Operating-System: FreeBSD 9.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? User-Agent: Mutt/1.5.16 (2007-06-09) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, dougb@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r204824 - head/sys/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2010 04:49:38 -0000 On Tue, Mar 09, 2010 at 07:35:12PM -0700, M. Warner Losh wrote: > > I'd recommend something similar to the following change: > Index: newvers.sh .. > +S=sys .. > -*/sys/*) > +*/$S/*) > SRCDIR=${d##*obj} > if [ -n "$MACHINE" ]; then > SRCDIR=${SRCDIR##/$MACHINE} > fi > - SRCDIR=${SRCDIR%%/sys/*} > + SRCDIR=${SRCDIR%%/$S/*} Why not make it simpler as my patch did? Do you not trust that newvers.sh (e.g. "$0") is within the kernel directory? > which would allow people that move sys to somewhere else to change one > line and still have everything work. They are going to have to make > changes anyway to support that, since it isn't supported by FreeBSD > out of the box. Eh? 'svn co svn://svn.freebsd.org/base/head/sys syshead' works as-is. Using "$0" requires no one to have to change a single line. -- -- David (obrien@FreeBSD.org)