From owner-freebsd-current@freebsd.org Thu Aug 8 01:33:56 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 43D0EBEC10 for ; Thu, 8 Aug 2019 01:33:56 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 463rW70GQlz4cFl for ; Thu, 8 Aug 2019 01:33:54 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f52.google.com with SMTP id b7so61940477otl.11 for ; Wed, 07 Aug 2019 18:33:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=vjSwqKoDoC1o+ALv3dZ1Zcr1iFN8Jq2UYWj7KFeTyGw=; b=PWqDm7PWUUO++tX5Xn509o8xpp5bberBiTgmhh+RhyWwPzo50EInXaqeyHp/AYkOAg vIaOdXTTcXrVBT6ZTPLtZ7mQwL3CNeyQMNzRnmKdIsaI9Lphvzf5LdaQPihjvoajkRAw Aaf3Z1cHQdZ7BDi+pVuYp8z2HtB9YX1GPGZoKbAflM36k0uWKxJJLiE56u+NIY7xYaPi pAocrbykKUHtS53pPvZ8tFM2GIFicyQNR4NmGU7I+ydUqLzggV2jXNGpFWfIvyt4whhx QzHT9gI+yNBLXRQRQwEqLcLQ8atin5VhT9o8lf4qu10/qXA212UXMGVrpVrz25dr6mHB hsnw== X-Gm-Message-State: APjAAAWKgkImyf/1JvuEpOF+BNi1cTqWelIAkhuXgn6QwDQdhwUJ8pbF wA/seSi7sHiV7GDVOOuBS0AMvFsNPHg= X-Google-Smtp-Source: APXvYqw34lkCJDA0aLmdhg7ro7jfv3xCJ61f6YyUf1x5yqQwlN6dEwDG5r/2bi2vH/tr1kJNj9EDBQ== X-Received: by 2002:aca:39c4:: with SMTP id g187mr842095oia.8.1565228033596; Wed, 07 Aug 2019 18:33:53 -0700 (PDT) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com. [209.85.210.51]) by smtp.gmail.com with ESMTPSA id p188sm32163351oic.54.2019.08.07.18.33.53 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 07 Aug 2019 18:33:53 -0700 (PDT) Received: by mail-ot1-f51.google.com with SMTP id o101so112163109ota.8 for ; Wed, 07 Aug 2019 18:33:53 -0700 (PDT) X-Received: by 2002:a6b:6409:: with SMTP id t9mr1361516iog.270.1565228033075; Wed, 07 Aug 2019 18:33:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 7 Aug 2019 18:33:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: SVN r350713 breaks non-debug kernel builds To: Michael Butler Cc: freebsd-current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 463rW70GQlz4cFl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.210.52 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-4.30 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; RWL_MAILSPIKE_GOOD(0.00)[52.210.85.209.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; RCPT_COUNT_TWO(0.00)[2]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[52.210.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.30)[ip: (-0.62), ipnet: 209.85.128.0/17(-3.39), asn: 15169(-2.43), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 01:33:56 -0000 Thanks for the report Michael, and sorry about the breakage. I believe this patch should fix the build, and I am testing it now: --- sys/kern/kern_sysctl.c (revision 350714) +++ sys/kern/kern_sysctl.c (working copy) @@ -55,6 +55,7 @@ #include #include #include +#include #include #include #include @@ -67,7 +68,6 @@ #endif #ifdef DDB -#include #include #include #endif On Wed, Aug 7, 2019 at 6:23 PM Michael Butler wrote: > > As follows .. > > --- kern_sysctl.o --- > /usr/src/sys/kern/kern_sysctl.c:1623:19: error: use of undeclared > identifier 'kdb_active' > if (arg2 == 0 || kdb_active) { > ^ > 1 error generated. > *** [kern_sysctl.o] Error code 1 > > imb > >