From owner-freebsd-multimedia@FreeBSD.ORG  Fri May  6 16:11:36 2011
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84D5F1065672;
	Fri,  6 May 2011 16:11:36 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 5F4A68FC1A;
	Fri,  6 May 2011 16:11:36 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id EF2E646B3C;
	Fri,  6 May 2011 12:11:35 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 89FEC8A01B;
	Fri,  6 May 2011 12:11:35 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org,
 multimedia@freebsd.org
Date: Fri, 6 May 2011 09:00:08 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; )
References: <4DC3B764.4030801@FreeBSD.org>
In-Reply-To: <4DC3B764.4030801@FreeBSD.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201105060900.08672.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Fri, 06 May 2011 12:11:35 -0400 (EDT)
Cc: Andriy Gapon <avg@freebsd.org>
Subject: Re: dsp mmap change
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 May 2011 16:11:36 -0000

On Friday, May 06, 2011 4:55:00 am Andriy Gapon wrote:
> 
> I would like to ask for a review and/or testing of the following patch:
> http://people.freebsd.org/~avg/dev_dsp_mmap.diff
> 
> It's supposed to fix an issue described here:
> http://lists.freebsd.org/pipermail/freebsd-multimedia/2011-
February/011691.html
> 
> In short, the following pseudo-code should do the right thing:
> fd = open(/dev/dsp, O_RDWR);
> mmap(PROT_READ, fd);
> mmap(PROT_WRITE, fd);

Are the buffers statically allocated?

-- 
John Baldwin