Date: Wed, 7 Mar 2018 15:18:53 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Eitan Adler <eadler@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 Message-ID: <201803072318.w27NIrI6056501@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CAF6rxgmQBX_Oq_BW-6K94obSGhigRqMtkhhYvOCypoiVte85MQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 7 March 2018 at 09:37, John Baldwin <jhb@freebsd.org> wrote: > > On Tuesday, March 06, 2018 06:46:37 PM Eitan Adler wrote: > >> On 6 March 2018 at 08:26, John Baldwin <jhb@freebsd.org> wrote: > >> > On Monday, March 05, 2018 07:13:59 PM Eitan Adler wrote: > >> >> On 5 March 2018 at 10:08, John Baldwin <jhb@freebsd.org> wrote: > >> >> > On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote: > >> >> >> Author: eadler > >> >> >> Date: Mon Mar 5 07:54:57 2018 > >> >> >> New Revision: 330451 > >> >> >> URL: https://svnweb.freebsd.org/changeset/base/330451 > >> >> >> > >> >> >> Log: > >> >> >> MFC r306837: > >> >> >> > >> >> >> [net80211] extend the ieee80211_rx_stats struct to include more information. > >> >> > > >> >> > Have you thought about the KBI implications of this change and some of the > >> >> > other changes you've merged? > >> >> > >> >> I do have a copy of the modules from 11.1 and have loaded them at > >> >> various points in time after merging. That said, I am not perfect. > >> >> Unfortunately, my -STABLE box did not have fully functioning drivers > >> >> before these changes so its difficult to test anything beyond "loads > >> >> and does not panic.". I havn't done so today yet, but that will happen > >> >> soon. > >> >> > >> >> Ensuring these things work through code inspection is certainly > >> >> possible and I've skipped over several changes as a result. > >> > > >> > Loading a module doesn't alone doesn't actually test for breakage. > >> > >> I'm aware. In this case I should likely just revert this change since > >> its a pretty blatant break. > > > > I suspect many of these changes for iwm, etc. are all intertwined so I'm not > > sure if you can leave out individual ones. > > Possibly. I do have iwm working on my laptop though. I also know of > one open PR assigned to me w.r.t. a model I don't own. I'll be > addressing it some time this week. I believe I also have a tester of stable/11 iwm patches avaliable, he has an 8265? -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201803072318.w27NIrI6056501>