From owner-cvs-src@FreeBSD.ORG Fri Jun 15 02:32:09 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B349716A468; Fri, 15 Jun 2007 02:32:09 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-3.cisco.com (sj-iport-3-in.cisco.com [171.71.176.72]) by mx1.freebsd.org (Postfix) with ESMTP id 7EBB213C487; Fri, 15 Jun 2007 02:32:09 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-3.cisco.com ([171.71.179.195]) by sj-iport-3.cisco.com with ESMTP; 14 Jun 2007 19:32:09 -0700 X-IronPort-AV: i="4.16,422,1175497200"; d="scan'208"; a="494376185:sNHT52109598" Received: from sj-core-2.cisco.com (sj-core-2.cisco.com [171.71.177.254]) by sj-dkim-3.cisco.com (8.12.11/8.12.11) with ESMTP id l5F2W9kX024357; Thu, 14 Jun 2007 19:32:09 -0700 Received: from xbh-sjc-231.amer.cisco.com (xbh-sjc-231.cisco.com [128.107.191.100]) by sj-core-2.cisco.com (8.12.10/8.12.6) with ESMTP id l5F2W8aO025851; Fri, 15 Jun 2007 02:32:09 GMT Received: from xfe-sjc-212.amer.cisco.com ([171.70.151.187]) by xbh-sjc-231.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 14 Jun 2007 19:32:03 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-212.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 14 Jun 2007 19:32:03 -0700 Message-ID: <4671FA96.1010304@cisco.com> Date: Thu, 14 Jun 2007 22:33:58 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070601 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <200706142259.l5EMx4aW053356@repoman.freebsd.org> <20070615001917.GA94743@rot13.obsecurity.org> <4671F88B.7030003@cisco.com> <20070615022956.GA96741@rot13.obsecurity.org> In-Reply-To: <20070615022956.GA96741@rot13.obsecurity.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 15 Jun 2007 02:32:03.0275 (UTC) FILETIME=[5BBE09B0:01C7AEF5] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=3024; t=1181874729; x=1182738729; c=relaxed/simple; s=sjdkim3002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20cvs=20commit=3A=20src/sys/netinet=20sctp.h=20sctp_asc onf.c=20sctp_asconf.h=0A=20sctp_bsd_addr.c=20sctp_constants.h=20sctp_indat a.c=20sctp_input.c=20sctp_lock_bsd.h=0A=20sctp_os_bsd.h=20sctp_output.c=20 sctp_pcb.c=20sctp_pcb.h=20sctp_peeloff.c=20sctp_sysctl.c=0A=20sctp_sysctl. h=20sctp_timer.c=20sctp_uio.h=20... |Sender:=20; bh=Nt6HgZEJ64GFYJqfBzHEcbTvfIzsbr2gIwz0bbwhcXk=; b=u0I5rG0ZDdwU9pzVro/HoUBYlDkkEuy55nrVC1L35nMMiwbKYiknXW2nj629MhefgBmD5ED6 yliJRbpCV4grqK2lxrQvqnfR8UNCEldgoChi+RgpIIc2h50DGMbfT/C5; Authentication-Results: sj-dkim-3; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim3002 verified; ); Cc: Randall Stewart , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet sctp.h sctp_asconf.c sctp_asconf.h sctp_bsd_addr.c sctp_constants.h sctp_indata.c sctp_input.c sctp_lock_bsd.h sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_sysctl.c sctp_sysctl.h sctp_timer.c sctp_uio.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2007 02:32:09 -0000 Kris Kennaway wrote: > On Thu, Jun 14, 2007 at 10:25:15PM -0400, Randall Stewart wrote: > >>Kris Kennaway wrote: >> >>>On Thu, Jun 14, 2007 at 10:59:04PM +0000, Randall Stewart wrote: >>> >>> >>>>rrs 2007-06-14 22:59:04 UTC >>>> >>>>FreeBSD src repository >>>> >>>>Modified files: >>>> sys/netinet sctp.h sctp_asconf.c sctp_asconf.h >>>> sctp_bsd_addr.c sctp_constants.h >>>> sctp_indata.c sctp_input.c >>>> sctp_lock_bsd.h sctp_os_bsd.h >>>> sctp_output.c sctp_pcb.c sctp_pcb.h >>>> sctp_peeloff.c sctp_sysctl.c >>>> sctp_sysctl.h sctp_timer.c sctp_uio.h >>>> sctp_usrreq.c sctputil.c sctputil.h >>>> sys/netinet6 sctp6_usrreq.c >>>> sys/conf options >>>>Log: >>>>- Fix so ifn's are properly deleted when the ref count goes to 0. >>>>- Fix so VRF's will clean themselves up when no references are around. >>>>- Allow sctp_ifa to be passed into inpcb_bind, addr_mgmt_ep_sa to bypass >>>> normal validation checks. >>>>- turn auto-asconf off for subset bound sockets >>>>- Moves all logging to use KTR. This gets rid of most >>>> of the logging #ifdef's with a few exceptions reducing >>>> the number of config options for SCTP. >>> >>> >>>| +#ifndef SCTP_SUBSYS_KTR >>>| +#define SCTP_SUBSYS_KTR KTR_GEN >>>| +#endif >>> >>>Brief silence after previous disapproval doesn't equal approval ;-) >>> >>>What was wrong with the method I suggested, namely using KTR_SUBSYS if >>>a SCTP_TRACE option is included in the kernel? That is the intended >>>way that events local to a particular subsystem should be handled. >>> >>>Kris >> >>I asked if KTR_GEN was ok.. I can use KTR_SUBSYS.. sure.. but that >>means I can't really run witness on my machine as I test.. since >>witness is the only one that uses KTR_SUBSYS.. No one else uses >>KTR_GEN.. why is it a problem using one. > > > WITNESS does not use itq: > > #if 0 > #define KTR_WITNESS KTR_SUBSYS > #else > #define KTR_WITNESS 0 > #endif > > KTR_WITNESS is used for debugging of the WITNESS code itself (probably > no-one has needed to use it for many years). It is a completely > orthogonal purpose to yours, so they can co-exist happily. > > KTR_GEN is for "general events". SCTP is not a general event, it's > localized events belonging to a particular subsystem. > > >>So whats wrong with using a unused one? > > > If you look at the history there was a big effort to reclaim these > fields. Because space is at such a premium here there needs to be a > strong reason for using up a spare field. SCTP does not strike me as > such a reason, particularly since the alternative seems quite > practical. > > Kris Ok.. whatever you say.. I can change it very easily ;-) R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)