From owner-freebsd-current@FreeBSD.ORG Sun Feb 22 06:42:11 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA32E16A4CE for ; Sun, 22 Feb 2004 06:42:11 -0800 (PST) Received: from tx0.oucs.ox.ac.uk (tx0.oucs.ox.ac.uk [129.67.1.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DB5D43D1D for ; Sun, 22 Feb 2004 06:42:11 -0800 (PST) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from scan0.oucs.ox.ac.uk ([129.67.1.162] helo=localhost) by tx0.oucs.ox.ac.uk with esmtp (Exim 4.24) id 1Auuo6-00063C-EB for current@freebsd.org; Sun, 22 Feb 2004 14:42:10 +0000 Received: from rx0.oucs.ox.ac.uk ([129.67.1.161]) by localhost (scan0.oucs.ox.ac.uk [129.67.1.162]) (amavisd-new, port 25) with ESMTP id 22867-09 for ; Sun, 22 Feb 2004 14:42:10 +0000 (GMT) Received: from gateway.wadham.ox.ac.uk ([163.1.161.253]) by rx0.oucs.ox.ac.uk with smtp (Exim 4.24) id 1Auuo6-000639-0l for current@freebsd.org; Sun, 22 Feb 2004 14:42:10 +0000 Received: (qmail 31094 invoked by uid 0); 22 Feb 2004 14:42:09 -0000 Received: from colin.percival@wadham.ox.ac.uk by gateway by uid 71 with qmail-scanner-1.16 (sweep: 2.14/3.71. spamassassin: 2.53. Clear:. Processed in 1.73402 secs); 22 Feb 2004 14:42:09 -0000 X-Qmail-Scanner-Mail-From: colin.percival@wadham.ox.ac.uk via gateway X-Qmail-Scanner: 1.16 (Clear:. Processed in 1.73402 secs) Received: from dhcp1131.wadham.ox.ac.uk (HELO piii600.wadham.ox.ac.uk) (163.1.161.131) by gateway.wadham.ox.ac.uk with SMTP; 22 Feb 2004 14:42:07 -0000 Message-Id: <6.0.1.1.1.20040222143518.03ac9a10@imap.sfu.ca> X-Sender: cperciva@imap.sfu.ca (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.1.1 Date: Sun, 22 Feb 2004 14:42:06 +0000 To: current@freebsd.org From: Colin Percival In-Reply-To: <20040222135129.28E207303A@freebsd-current.sentex.ca> References: <20040222135129.28E207303A@freebsd-current.sentex.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed cc: harti@freebsd.org Subject: Re: [current tinderbox] failure on ia64/ia64 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Feb 2004 14:42:11 -0000 At 13:51 22/02/2004, FreeBSD Tinderbox wrote: >/other/tinderbox/CURRENT/ia64/ia64/src/sys/dev/hfa/fore_command.c: In >function `fore_cmd_allocate': >/other/tinderbox/CURRENT/ia64/ia64/src/sys/dev/hfa/fore_command.c:108: >warning: comparison between pointer and integer >/other/tinderbox/CURRENT/ia64/ia64/src/sys/dev/hfa/fore_command.c: In >function `fore_cmd_free': >/other/tinderbox/CURRENT/ia64/ia64/src/sys/dev/hfa/fore_command.c:461: >warning: assignment makes integer from pointer without a cast >*** Error code 1 Could someone please fix this? Index: src/sys/dev/hfa/fore_command.c =================================================================== RCS file: /home/ncvs/src/sys/dev/hfa/fore_command.c,v retrieving revision 1.17 diff -u -r1.17 fore_command.c --- src/sys/dev/hfa/fore_command.c 21 Feb 2004 19:08:23 -0000 1.17 +++ src/sys/dev/hfa/fore_command.c 22 Feb 2004 14:38:22 -0000 @@ -107,3 +107,3 @@ pmemp = vtophys(fup->fu_cmd_stat); - if (pmemp == NULL) { + if (pmemp == 0) { return (1); @@ -460,3 +460,3 @@ fup->fu_cmd_stat = NULL; - fup->fu_cmd_statd = NULL; + fup->fu_cmd_statd = 0; } Colin Percival