From owner-svn-src-head@freebsd.org Thu Aug 8 09:47:01 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0FAB2C97D4; Thu, 8 Aug 2019 09:47:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4643S46CZBz45qH; Thu, 8 Aug 2019 09:47:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x52b.google.com with SMTP id r26so7827785pgl.10; Thu, 08 Aug 2019 02:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=Saln8UERDn2b8ucAEk6bPXGchYkzEQo2xHutO/Fgx5s=; b=oAzs6Z40o1Dxtv20VeUHeHk4Ct4KcUfNuFyZq2uyKy7blAwdr1uSDp4h/6NKXca21H lj1LijV3OyPRq0I867yOVkGR5rbPOmRjpknOirzOFGU0JRVZvD9KDqBML7jyLrZTAtJx LUZFMNMcMj8el+jVkC5lxVfMlvH0KBBtFnVFSu6cnMl5eZZdjBwEbUy8zRXa/cwr1ZAw pWZ1qKC6gCbfeZHt4v8FA208ltiln4clwaxeKF37Zb1Ydx96gOXGIeGo0bpsnCDIBy9Z nvHjiD3AUy1RiMKWjUq5k33Fd1FQCUV/X+WhQZn6QB4kVubl49ieKb5Mlo03/R/Do2vp lQ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=Saln8UERDn2b8ucAEk6bPXGchYkzEQo2xHutO/Fgx5s=; b=A06hzhi8Lh194dWMsXaYw/s5f39liO/5+Fo6nH6rHUHhejjeSHtb/cRk1VabGN8z/q Xyd8OLuoLK2TaVvQ3aIuk3mzATDKHFBABcANrDkkEq1tzwvT9BwiQdYFvXtZuUyd7PJw cKai8un80PnZ/qmwgwaAsxf4SsEyJ0K6QhhQgiHauMc1mN0lnpgJwJQ9gUdsQ1xRGmz9 FqCqBzGRXron0BzdZRHQfp9u8jWEW162kMjHSR6bSut0h4rNNqcj3o0kl7vc8RmsuXeO xfW67H5Dgk7Dc6+aWZCuMH5G9vG24KS54qmpTkdzc1LlHnc1W8q9H4kUgNb0AjIXYVWC NWAA== X-Gm-Message-State: APjAAAVdPJ63BI0JKEbLj+6B2C3GB992MTDNU406GbsOuSjmETqkTFy3 EUdlKopVou2jY2/foL9CCInurNeL3zQ= X-Google-Smtp-Source: APXvYqybaQR4hZwBBVAe2KaLqoT8MxOwi9OKJbMuNhwMdprUvMc8KCz72UyMm+WaYZUxbbHyVUrqsQ== X-Received: by 2002:a17:90a:25c8:: with SMTP id k66mr3129999pje.129.1565257618586; Thu, 08 Aug 2019 02:46:58 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id n185sm81530960pga.16.2019.08.08.02.46.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Aug 2019 02:46:57 -0700 (PDT) From: Enji Cooper Message-Id: <50736BCD-21A8-4E59-92F7-DBFE60E652DA@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r350512 - head/tests/sys/kern Date: Thu, 8 Aug 2019 02:46:56 -0700 In-Reply-To: Cc: Mark Johnston , src-committers , svn-src-all , svn-src-head@freebsd.org To: Li-Wen Hsu References: <201908011819.x71IJG0M076399@repo.freebsd.org> <20190807202732.GD1377@raichu> X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 4643S46CZBz45qH X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 09:47:01 -0000 > On Aug 7, 2019, at 2:04 PM, Li-Wen Hsu wrote: >=20 > On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston > wrote: >>=20 >> On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote: >>> Author: lwhsu >>> Date: Thu Aug 1 18:19:16 2019 >>> New Revision: 350512 >>> URL: https://svnweb.freebsd.org/changeset/base/350512 >>>=20 >>> Log: >>> Only skip test cases sometimes failing in CI when they are running = in CI >>>=20 >>> Suggested by: jhb >>> Sponsored by: The FreeBSD Foundation >>=20 >> This seems to break running the tests manually; atf dies because the >> "ci" variable is not defined. I have to use an invocation like this = to >> avoid that: >>=20 >> $ kyua -v test_suites.FreeBSD.ci=3Dfalse test ptrace_test >>=20 >> I suspect that share/mk/suite.test.mk needs to be augmented somehow = to >> set this variable to "false" by default, so that the CI = infrastructure >> can override that. >=20 > Thanks for catching this! I feel that the better approach is using > function that gets this variable with default value, for keeping > things simple. This is the right API to use: atf_tc_get_config_var_as_bool_wd(tc, variable_name, default_value); Just set the default to `false`. HTH, -Enji=