From owner-freebsd-firewire@FreeBSD.ORG  Thu Feb 12 17:04:53 2009
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9D36A1065672
	for <freebsd-firewire@freebsd.org>;
	Thu, 12 Feb 2009 17:04:53 +0000 (UTC)
	(envelope-from sean.bruno@dsl-only.net)
Received: from iron2.pdx.net (iron2.pdx.net [69.64.224.71])
	by mx1.freebsd.org (Postfix) with ESMTP id 609DD8FC14
	for <freebsd-firewire@freebsd.org>;
	Thu, 12 Feb 2009 17:04:53 +0000 (UTC)
	(envelope-from sean.bruno@dsl-only.net)
Received: (qmail 24599 invoked from network); 12 Feb 2009 09:04:16 -0800
Received: from 069-064-235-060.pdx.net (HELO ?192.168.1.51?) (69.64.235.60)
	by iron2.pdx.net with SMTP; 12 Feb 2009 09:04:16 -0800
From: Sean Bruno <sean.bruno@dsl-only.net>
To: Ganbold <ganbold@micom.mng.net>
In-Reply-To: <4994320B.4060900@micom.mng.net>
References: <1234414082.30696.185.camel@localhost.localdomain>
	<4994320B.4060900@micom.mng.net>
Content-Type: text/plain
Date: Thu, 12 Feb 2009 09:04:51 -0800
Message-Id: <1234458291.30696.186.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) 
Content-Transfer-Encoding: 7bit
Cc: scottl@freebsd.org, freebsd-firewire@FreeBSD.org
Subject: Re: Final patch for -current
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Firewire support in FreeBSD <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2009 17:04:53 -0000

On Thu, 2009-02-12 at 22:28 +0800, Ganbold wrote:
> Sean,
> 
> How about following redundant loop near the end of fwohci.c?
> 
> --- sys/dev/firewire/fwohci.c	2008-11-22 14:39:45.000000000 +0800
> +++ /var/current/mysrc/sys/dev/firewire/fwohci.c	2008-11-25 11:36:09.000000000 +0800
> @@ -2973,7 +2973,7 @@
>  		db_tr = STAILQ_NEXT(db_tr, link);
>  		resCount = FWOHCI_DMA_READ(db_tr->db[0].db.desc.res)
>  						& OHCI_COUNT_MASK;
> -	} while (resCount == 0)
> +	}
>  	printf(" done\n");
>  	dbch->top = db_tr;
>  	dbch->buf_offset = dbch->xferq.psize - resCount;
> 
> thanks,
> 
> Ganbold

Yep.  That should die.  Let me test it.

Sean