From nobody Thu Aug 31 20:18:15 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RcCCX13Bhz4rZBx for ; Thu, 31 Aug 2023 20:18:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RcCCW73HSz3FB7 for ; Thu, 31 Aug 2023 20:18:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693513096; a=rsa-sha256; cv=none; b=q657dcbrskv3LN0uh9JRteLjoBZTdpUdnDys3Owyb51Ep/b/mmPcA2EL3DCxEjTDUYzTPw 9PyXciuC/PX9gtRhuzwjL34gBr8rnKL5XxuuoHQJ4IhctAc77XsGZtu0mzqE/1TQkLrCJ4 O94QWzsaB6FwFqTyNYxojM2NZP/e0IMtgSCj/9omzbkMI3/sMbrDUSp23Of3X12mRjpi3l xIglQLxKpqard01Gd+gU2HPnLXFOrqoGs2MaN6nLIv+Zk8el3HiaSOU0ZzqaPNUJggaXDO yvWZf4k0RAwEO9rsPdXGjr7t+8tx/dCPlBZxx18hULGhQMpKl1tg+jaMsxKSww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693513096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w8rgAyHzVo8MACz9fjF+Hs0uPdXa/CZW8rwG3eGZjOA=; b=beu7T7IFiYI36hRZbao6B9cS0noHzvY296cdWX0l8TqsdPfT5rc9YHlKkEz5wbwIyuWHjF 6FJS/ZMKACZOWX6X7rQUxLH/BkH9/a5ODyJkd5uNF2S1mHQ1gCV9TbgYXH00884mYAerQS Syu1WF8GoCoZNk66Vvz6pIF32CfNWKIEC4Mksq0RAqVs1NxWfIOvx4AaWpnVi3qUUG+vI5 S7NN7QKNLX+SdNTw0o5+Q+ZWn37XQga0eFs56B7JQSuMbUVWzMfqIFttOOpsVpEUA+Qwxv qVj4/4GbNUs1Fy02IKCaNk4YzjRSS5Ls4UjREaWoPUeiPs8htLRaHkNzgxKdBQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RcCCW6838zXd4 for ; Thu, 31 Aug 2023 20:18:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 37VKIFY0078478 for ; Thu, 31 Aug 2023 20:18:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 37VKIFSt078476 for net@FreeBSD.org; Thu, 31 Aug 2023 20:18:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 221122] Attaching interface to a bridge stops all traffic on uplink NIC for few seconds Date: Thu, 31 Aug 2023 20:18:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: spork@bway.net X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221122 --- Comment #33 from spork@bway.net --- Some additional testing here... There are two workarounds presented in this thread: - Add "-txcsum -tso4 -tso6 -txcsum6" (or whatever your NIC requires) to the ifconfig statement for your interface(s) in rc.conf. This requires knowing = what you need to disable to make sure your NIC and epair have equal capabilities= so that when the epair interface is added to the bridge, there's no need to re= init the NIC to make the capabilities match, and therefore, no connectivity loss. - Pre-plumb the bridge and epair interfaces by adding them to rc.conf's cloned_interfaces and add the epair to the "addm" ifconfig line. On boot, t= he "addm" runs and we don't care about the reinit of the NIC because it's duri= ng boot. This method does not require knowing what capabilities need to be disabled on the NIC. I'm finding neither of these actually work as workarounds, because in 13.2 = with my ixl NICs I can see both with iocage (a jail shutdown or restart) and with manual ifconfig commands (removing a vtnet interface from a bridge) cause t= he NIC to reinit. In other words, removing an epair/vtnet interface from a bri= dge seems to put the offloading capabilities back in place, rendering either workaround useless. Again, I'm not clear on what the fix was that was mentioned in comment #28,= so if I'm way off base here, let me know! Example follows... We have a bridge containing my external ixl interface and an epair/vtnet interface from a jail: [root@clweb5 /home/spork]# ifconfig bridge0 bridge0: flags=3D8843 metric 0 mtu = 1500 ether 58:9c:fc:10:ff:d9 id 00:00:00:00:00:00 priority 32768 hellotime 2 fwddelay 15 maxage 20 holdcnt 6 proto rstp maxaddr 2000 timeout 1200 root id 00:00:00:00:00:00 priority 32768 ifcost 0 port 0 member: vnet0.10 flags=3D143 ifmaxaddr 0 port 7 priority 128 path cost 2000 member: ext0 flags=3D143 ifmaxaddr 0 port 1 priority 128 path cost 55 groups: bridge nd6 options=3D9 The ext0 (ixl) interface was already a member of the bridge when the jail started to there was NO NIC reinit/loss of connectivity when the jail start= ed (good!). ext0 options look like this while a member of bridge0 (ie: txcsum and two f= or v4 and v6 are disabled): ext0: flags=3D8963 metric 0= mtu 1500 =20=20=20=20=20=20=20 options=3D4a500b9 Now I manually pull vtnet0.10 from the above bridge: [root@clweb5 /home/spork]# ifconfig bridge0 deletem vnet0.10 And we see connectivity drop for 5 seconds: Aug 31 15:32:57 clweb5 kernel: vnet0.10: promiscuous mode disabled Aug 31 15:32:57 clweb5 kernel: ext0: link state changed to DOWN Aug 31 15:33:02 clweb5 kernel: ext0: Link is up, 1 Gbps Full Duplex, Reques= ted FEC: None, Negotiated FEC: None, Autoneg: True, Flow Control: None Aug 31 15:33:02 clweb5 kernel: ext0: link state changed to UP And we see why - removing the vtnet bridge member causes something(?) to put all the flags I'd removed from ext0 back in place (txcsum, txcsum6, tso4, tso6): [root@clweb5 /home/spork]# ifconfig ext0 ext0: flags=3D8963 metric 0= mtu 1500 =20=20=20=20=20=20=20 options=3D4e503bb Again, this is me manually removing the interface from the bridge, not ioca= ge. Standard jails and iocage jails both call a "destroy" on the vtnet/epair interface, so this isn't just an iocage issue. Sorry this is so long... anyhow the questions again: - Did the prior workarounds "work" and then stop working later? - Did the behavior of bringing explicitly-removed flags back to an interface when members are removed from a bridge change at some point? - What was the fix in comment #28? --=20 You are receiving this mail because: You are the assignee for the bug.=