From owner-cvs-src@FreeBSD.ORG Sun Feb 1 03:59:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA40116A4D0; Sun, 1 Feb 2004 03:59:23 -0800 (PST) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4500443D54; Sun, 1 Feb 2004 03:59:22 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i11BxGLE005762; Sun, 1 Feb 2004 22:59:16 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i11BxEt4028447; Sun, 1 Feb 2004 22:59:15 +1100 Date: Sun, 1 Feb 2004 22:59:14 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Jeff Roberson In-Reply-To: <20040201012325.U36463-100000@mail.chesapeake.net> Message-ID: <20040201224736.P8564@gamplex.bde.org> References: <20040201012325.U36463-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: Jeff Roberson cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2004 11:59:25 -0000 On Sun, 1 Feb 2004, Jeff Roberson wrote: > On Sat, 31 Jan 2004, Jeff Roberson wrote: > > > jeff 2004/01/31 22:20:18 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/kern sched_4bsd.c > > Log: > > - Disable ithread binding in all cases for now. This doesn't make as much > > sense with sched_4bsd as it does with sched_ule. > > - Use P_NOLOAD instead of the absence of td->td_ithd to determine whether or > > not a thread should be accounted for in sched_tdcnt. > > Well, this never reports a load of less than 1, but it's more "correct" > than it was. Bruce, do you know why it's not going lower than 1? This is because P_NOLOAD is used before it is set for the pagezero thread. Unlike other threads, pagezero sets P_NOLOAD after it starts running. So sched_tdcnt is incremented when pagezero is first run. Then when it switches after setting P_NOLOAD, sched_tdcnt is not decremented. Bruce