From owner-p4-projects@FreeBSD.ORG  Sat Jul 10 13:58:29 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4072F16A4D0; Sat, 10 Jul 2004 13:58:29 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0575316A4CE
	for <perforce@freebsd.org>; Sat, 10 Jul 2004 13:58:29 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DE60743D31
	for <perforce@freebsd.org>; Sat, 10 Jul 2004 13:58:28 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i6ADwSRs027331
	for <perforce@freebsd.org>; Sat, 10 Jul 2004 13:58:28 GMT
	(envelope-from davidxu@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i6ADwSvM027328
	for perforce@freebsd.org; Sat, 10 Jul 2004 13:58:28 GMT
	(envelope-from davidxu@freebsd.org)
Date: Sat, 10 Jul 2004 13:58:28 GMT
Message-Id: <200407101358.i6ADwSvM027328@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	davidxu@freebsd.org using -f
From: David Xu <davidxu@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 56958 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Jul 2004 13:58:29 -0000

http://perforce.freebsd.org/chv.cgi?CH=56958

Change 56958 by davidxu@davidxu_alona on 2004/07/10 13:58:25

	Introduce PT_SUSPEND to suspend thread, PT_RESUME to resume a thread
	previously suspended by debugger. Call thread_continued() hook after
	continued a process.

Affected files ...

.. //depot/projects/davidxu_ksedbg/src/sys/kern/sys_process.c#8 edit
.. //depot/projects/davidxu_ksedbg/src/sys/sys/ptrace.h#3 edit

Differences ...

==== //depot/projects/davidxu_ksedbg/src/sys/kern/sys_process.c#8 (text+ko) ====

@@ -559,6 +559,25 @@
 			goto fail;
 		PROC_UNLOCK(p);
 		return (0);
+
+	case PT_SUSPEND:
+		_PHOLD(p);
+		mtx_lock_spin(&sched_lock);
+		td2->td_flags |= TDF_DBSUSPEND;
+		mtx_unlock_spin(&sched_lock);
+		_PRELE(p);
+		PROC_UNLOCK(p);
+		return (0);
+
+	case PT_RESUME:
+		_PHOLD(p);
+		mtx_lock_spin(&sched_lock);
+		td2->td_flags &= ~TDF_DBSUSPEND;
+		mtx_unlock_spin(&sched_lock);
+		_PRELE(p);
+		PROC_UNLOCK(p);
+		return (0);
+
 	case PT_STEP:
 	case PT_CONTINUE:
 	case PT_TO_SCE:
@@ -640,14 +659,19 @@
 					p->p_xthread->td_xsig = data;
 					p->p_xthread = NULL;
 				}
-				thread_unsuspend(p);
 			} else {
 				td2->td_flags &= ~TDF_XSIG;
 				td2->td_xsig = data;
 				if (p->p_xthread == td2)
 					p->p_xthread = NULL;
-				thread_unsuspend_one(td2);
 			}
+			/*
+			 * unsuspend all threads, to not let a thread run,
+			 * you should use PT_SUSPEND to suspend it before
+			 * continuing process.
+			 */
+			thread_unsuspend(p);
+			thread_continued(p);
 			mtx_unlock_spin(&sched_lock);
 		} else if (data) {
 			psignal(p, data);

==== //depot/projects/davidxu_ksedbg/src/sys/sys/ptrace.h#3 (text+ko) ====

@@ -63,6 +63,8 @@
 #define PT_GETTHRLIST   41	/* get thread list */
 #define PT_CLEARSTEP    42	/* turn off single step */
 #define PT_SETSTEP      43	/* turn on single step */
+#define PT_SUSPEND      44	/* suspend a thread */
+#define PT_RESUME       45	/* resume a thread */
 #define PT_FIRSTMACH    64	/* for machine-specific requests */
 #include <machine/ptrace.h>	/* machine-specific requests, if any */