Date: Thu, 29 Jan 2015 16:38:43 -0500 From: "George Neville-Neil" <gnn@neville-neil.com> To: "Andrew Turner" <andrew@fubar.geek.nz> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org, Ian Lepore <ian@freebsd.org> Subject: Re: svn commit: r277835 - in head: lib/libpmc sys/arm/arm sys/arm/include sys/arm/ti sys/conf sys/dev/hwpmc sys/sys Message-ID: <AD250136-786A-45D8-B408-96CF99FF4682@neville-neil.com> In-Reply-To: <20150128192719.2baf6145@bender> References: <201501281608.t0SG88gs009253@svn.freebsd.org> <1422462903.15718.60.camel@freebsd.org> <20150128183913.GA44243@bsdpad.com> <20150128192719.2baf6145@bender>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 Jan 2015, at 14:27, Andrew Turner wrote: > On Wed, 28 Jan 2015 18:39:13 +0000 > Ruslan Bukin <br@FreeBSD.org> wrote: >> On Wed, Jan 28, 2015 at 09:35:03AM -0700, Ian Lepore wrote: >>> Just from a quick glance at the part that wasn't truncated, I >>> notice all the inline asm stuff is wrong -- it duplicates what's >>> already available in cpu-v6.h. >>> >> >> I had a conversation with Andrew this morning, he pointed me out >> those defines in cpu-v6.h, but we agreed those are optional stuff. >> I.e. duplicates != wrong. I'll fix that. Thanks > > It would be useful to use them, but this will need Makefile changes as > some of these defines are only available when __ARM_ARCH > 6 which may > not be true in userland. If we do make these changes we then need to > make sure that none of the code on the file built as ARMv7 is run on > an > ARMv6 as the compiler may choose to use invalid instructions on v6. I gather what is referred to here as defines are the macros that Ian (I think) added for access to the pmc and other fancy registers? I see that the hwpmc code has asm directly in it. Best, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AD250136-786A-45D8-B408-96CF99FF4682>