From owner-svn-ports-all@FreeBSD.ORG Mon Oct 8 17:02:45 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BD8251065670; Mon, 8 Oct 2012 17:02:45 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 93FA58FC16; Mon, 8 Oct 2012 17:02:44 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so2157580bkc.13 for ; Mon, 08 Oct 2012 10:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=zlzni5f6zVex1agObDKwVaDDmDdsEe++XIt0HKsZkIU=; b=XhEEoUH3I0/6CiINsxWIzXfE63w4ZKWo6MzCgyZuUEL3s042yJCfd5ELxSOC5OTvCh /u8OU6f2byN7ZuwB/CrRtBnsiqYsdCiDcm45jRHqN1RqCd3V2Pe6CKTD18CcyNlYl6ne nF3GBMPvXeCMCEk/NCUh9wd4mWpLPTwp9PuhpR6pde7kpXF59cKWSifqqjl3+R/qTBNd YvlFlt4/EyjyYbMNRfmc5gXsnb3W9Wfx/pVEJ0ayYAK5BhDYMqXceDV+tGqBr1GD5iDt xiJDQVmp4uWNwp+T4vj7wDhy2uwSXG+JwyfXU1JaI13tNWnaVqkcE62d7yKZdbQ+7C6H WH1g== Received: by 10.204.128.201 with SMTP id l9mr5492189bks.66.1349715763172; Mon, 08 Oct 2012 10:02:43 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.50.197 with HTTP; Mon, 8 Oct 2012 10:02:11 -0700 (PDT) In-Reply-To: <20121008071642.GA91360@ithaqua.etoilebsd.net> References: <201210061123.q96BNHVx053948@svn.freebsd.org> <20121008040154.GB91369@FreeBSD.org> <20121008045905.GD91369@FreeBSD.org> <20121008071642.GA91360@ithaqua.etoilebsd.net> From: Chris Rees Date: Mon, 8 Oct 2012 18:02:11 +0100 X-Google-Sender-Auth: -9dmlF06PHADGq7lCxDREhaz1bM Message-ID: To: Baptiste Daroussin Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305357 - head/net/ssvnc X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2012 17:02:45 -0000 On 8 October 2012 08:16, Baptiste Daroussin wrote: > On Mon, Oct 08, 2012 at 04:59:06AM +0000, Alexey Dokuchaev wrote: >> On Mon, Oct 08, 2012 at 04:01:54AM +0000, Alexey Dokuchaev wrote: >> > On Sat, Oct 06, 2012 at 11:23:17AM +0000, Baptiste Daroussin wrote: >> > > New Revision: 305357 >> > > URL: http://svn.freebsd.org/changeset/ports/305357 >> > > >> > > Log: >> > > fix sense of a test >> > > >> > > -.if ${PORT_OPTIONS:MULTRAFTP} >> > > +.if empty(PORT_OPTIONS:MULTRAFTP) >> > >> > That looks weird, and commit message is pretty cryptic as well. Could you >> > explain what went wrong here so others would not fall in the same pitfall? >> >> Err, I read is as ! vs. empty() test. Still, I've noticved some arguments >> on the syntax, would be nice to know if ! ${PORT_OPTIONS:M...} has issues >> other than purely stylish. >> > > No it hasn't (as far as I know) > This is all my fault-- I was the one who suggested the original use of ${FOO:M}, and I deliberately chose to retain empty(FOO) as the reverse because I was convinced that the insanity of make's conditionals would screw us over in some way. I have at [1] pulled together some simple tests, and I think I've caught all use cases here. It seems to work fine-- are there any people more wizardly than me with make that can confirm that it's OK? If so, I'll update the docs. Chris [1] http://www.bayofrum.net/~crees/scratch/Makefile-do-we-need-empty-after-all