From owner-freebsd-stable@FreeBSD.ORG Fri Jan 25 23:08:56 2008 Return-Path: Delivered-To: stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6699216A468; Fri, 25 Jan 2008 23:08:56 +0000 (UTC) (envelope-from sos@deepcore.dk) Received: from spider.deepcore.dk (cpe.atm2-0-70484.0x50a6c9a6.abnxx16.customer.tele.dk [80.166.201.166]) by mx1.freebsd.org (Postfix) with ESMTP id C49C813C46A; Fri, 25 Jan 2008 23:08:55 +0000 (UTC) (envelope-from sos@deepcore.dk) Received: from [194.192.25.138] (laptop.deepcore.dk [194.192.25.138]) by spider.deepcore.dk (8.13.8/8.13.8) with ESMTP id m0PN8gvL029135; Sat, 26 Jan 2008 00:08:42 +0100 (CET) (envelope-from sos@deepcore.dk) Message-Id: <9D0F5CA3-FE1E-40C1-A208-9BD377BCE4BB@deepcore.dk> From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= To: John Baldwin In-Reply-To: <200801250906.16186.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v915) Date: Sat, 26 Jan 2008 00:08:42 +0100 References: <559697920801231136s1dc42d42q41b614596e57fbf3@mail.gmail.com> <47979EFB.2050601@delphij.net> <00278157-73F7-4580-95DB-AAAA371DF924@deepcore.dk> <200801250906.16186.jhb@freebsd.org> X-Mailer: Apple Mail (2.915) Cc: d@delphij.net, stable@FreeBSD.ORG, Yoshihiko Sarumaru , freebsd-stable@FreeBSD.ORG, sos@FreeBSD.ORG Subject: Re: 6.3-RELEASE can not mount root on Cyrix 5530 ATA33 controller X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2008 23:08:56 -0000 On 25Jan, 2008, at 15:05 , John Baldwin wrote: > On Wednesday 23 January 2008 03:52:39 pm S=F8ren Schmidt wrote: >> On 23Jan, 2008, at 21:09 , Xin LI wrote: >> >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> Yoshihiko Sarumaru wrote: >>>> Hello, >>>> I updated my Geode GX1 PC from RELENG_6_2 to RELENG_6_3 and found >>>> root mount failed after reboot. >>>> >>>> This problem was caused by a change to ata-pci.c to pick up wider =20= >>>> old >>>> ata controller as ata-pci devices at ata_legacy() function, and >>>> roll backing >>>> that file resolved this problem for me. >>> >>> Which revision? >> >> Actually, its the fix to pci/pci.c that hasn't been backported to 6.x >> yet... > > Rev 1.343? It should apply to 6.x cleanly. Patch below: Yep, that one exactly. -S=F8ren > > > Index: pci.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /host/cvs/usr/cvs/src/sys/dev/pci/pci.c,v > retrieving revision 1.292.2.23 > diff -u -r1.292.2.23 pci.c > --- pci.c 10 Jan 2008 21:17:12 -0000 1.292.2.23 > +++ pci.c 25 Jan 2008 14:05:20 -0000 > @@ -1898,7 +1898,9 @@ > /* ATA devices needs special map treatment */ > if ((pci_get_class(dev) =3D=3D PCIC_STORAGE) && > (pci_get_subclass(dev) =3D=3D PCIS_STORAGE_IDE) && > - (pci_get_progif(dev) & PCIP_STORAGE_IDE_MASTERDEV)) > + ((pci_get_progif(dev) & PCIP_STORAGE_IDE_MASTERDEV) || > + (!pci_read_config(dev, PCIR_BAR(0), 4) && > + !pci_read_config(dev, PCIR_BAR(2), 4))) ) > pci_ata_maps(pcib, bus, dev, b, s, f, rl, force, = prefetchmask); > else > for (i =3D 0; i < cfg->nummaps;) > > > --=20 > John Baldwin > >