From owner-freebsd-bugs@FreeBSD.ORG  Sun May 29 15:45:30 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CAF4916A41C;
	Sun, 29 May 2005 15:45:30 +0000 (GMT)
	(envelope-from simon@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A8DD243D1D;
	Sun, 29 May 2005 15:45:30 +0000 (GMT)
	(envelope-from simon@FreeBSD.org)
Received: from freefall.freebsd.org (simon@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4TFjUf8057824;
	Sun, 29 May 2005 15:45:30 GMT
	(envelope-from simon@freefall.freebsd.org)
Received: (from simon@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4TFjUQa057820;
	Sun, 29 May 2005 15:45:30 GMT (envelope-from simon)
Date: Sun, 29 May 2005 15:45:30 GMT
From: "Simon L. Nielsen" <simon@FreeBSD.org>
Message-Id: <200505291545.j4TFjUQa057820@freefall.freebsd.org>
To: venglin@freebsd.lublin.pl, simon@FreeBSD.org, freebsd-bugs@FreeBSD.org,
	simon@FreeBSD.org
Cc: 
Subject: Re: bin/80661: [patch] [SECURITY] Missing NULL termination after
	strncpy() in rlogin(1)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 May 2005 15:45:31 -0000

Synopsis: [patch] [SECURITY] Missing NULL termination after strncpy() in rlogin(1)

State-Changed-From-To: open->feedback
State-Changed-By: simon
State-Changed-When: Sun May 29 15:33:56 GMT 2005
State-Changed-Why: 
We (the Security Team) can't find anywhere in the code-path where this
bug where this could lead to a situation that could be exploited as a
security vulnerability.  You could crash rlogin, but not in a way
which would cause it to execute arbitrary cod as root.  Have you found
any explicit place this bug could be exploited?

In any case, I have committed the patch to RELENG_4 since not NUL
terminating the buffer is certainly a bug, even it's not a security
bug.

Thanks for the report.  I'm keeping the PR open in feedback state for
now, since I would like to hear comments from Przemyslaw Frasunek
before totally closing this issue.


Responsible-Changed-From-To: freebsd-bugs->simon
Responsible-Changed-By: simon
Responsible-Changed-When: Sun May 29 15:33:56 GMT 2005
Responsible-Changed-Why: 
I will handle followups.

http://www.freebsd.org/cgi/query-pr.cgi?pr=80661