From owner-svn-ports-all@freebsd.org Tue Aug 29 22:40:26 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A8A8DE7749; Tue, 29 Aug 2017 22:40:26 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BE9873E24; Tue, 29 Aug 2017 22:40:26 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 90B8916185; Tue, 29 Aug 2017 22:40:25 +0000 (UTC) From: Jan Beich To: Johannes M Dieterich Cc: Jung-uk Kim , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448928 - in head/graphics: . drm-next-kmod References: <20170829205351.Horde.cJ-BkOZLFgXWSRXmqFSiczx@www.poelloepaeae.de> Date: Wed, 30 Aug 2017 00:40:09 +0200 In-Reply-To: <20170829205351.Horde.cJ-BkOZLFgXWSRXmqFSiczx@www.poelloepaeae.de> (Johannes M. Dieterich's message of "Tue, 29 Aug 2017 20:53:51 +0000") Message-ID: <4lsq-vvzq-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 22:40:26 -0000 Johannes M Dieterich writes: > Jung-uk Kim =E2=80=93 Tue., 29. August 2017 16:46 >> On 08/29/2017 13:13, Jan Beich wrote: >> > Johannes M Dieterich writes: >> >=20 >> >> Author: jmd >> >> Date: Tue Aug 29 16:32:19 2017 >> >> New Revision: 448928 >> >> URL: svnweb.freebsd.org/changeset/ports/448928 >> >> >> >> Log: >> >> New port: graphics/drm-next-kmod. >> > [...] >> >> +USES=3D kmod uidfix >> >=20 >> > Fails to build if SRC_BASE !=3D /usr/src. With SRCTOP undefined the po= rt >> > relies on /sys symlink existing and pointing to a real location. The >> > latter conflicts with $SRC_BASE/etc/Makefile hardcoding "usr/src/sys". >> >=20 >> > Maybe add MAKE_ENV =3D SRCTOP=3D"${SRC_BASE}" to fix the following. >> >=20 >> > $ make DISABLE_MAKE_JOBS=3D >> > =3D=3D=3D> Building for drm-next-kmod-g20170825 >> > =3D=3D=3D> drm (all) >> > Warning: Object directory not changed from original /usr/ports/graphic= s/drm-next-kmod/work/kms-drm-4ee5acb/drm >> > =3D=3D=3D> amd (all) >> > make[3]: >> > "/usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/amd/Makefile" >> > line 3: Cannot open /sys/conf/kern.opts.mk >> > make[3]: Fatal errors encountered -- cannot continue >> > make[3]: stopped in /usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee= 5acb/amd >> > *** Error code 1 > > ... my understanding is that for kmods we require /usr/src? Custom base system source location when building kernel modules has been supported for a long time, probably as long as non-root builds. Before SRC_BASE existed such ports usually relied on SYSDIR directly which is defined by bsd.kmod.mk. > I checked with kwm and he pointed out that people not > running /non-usr/src systems should set SRC_BASE properly in their > Mk/Uses/kmod.mk (I haven't tested this). I have both SRC_BASE and SYSDIR defined via environment. No issues with other -kmod ports for >5 years. Did you miss that this port doesn't respect SRC_BASE at all?