From owner-svn-src-head@freebsd.org Thu Jun 1 18:27:22 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7583CB7BCEC; Thu, 1 Jun 2017 18:27:22 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3D9441E0; Thu, 1 Jun 2017 18:27:22 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id u26so8126932pfd.2; Thu, 01 Jun 2017 11:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=d5T5DiW1azUMCdgU6fO5gaNT0Ga90Fqig2abiRnRkuA=; b=BhtvR6hN/hR0sOqJcwsPX8xRN9VEGAD2NWwj1Xq0WsqEPvmXimw1FKhVPmDaitIDoW uP98NgYsW0Dxf/DtvbXe3cA98QsYSJmEMZo1RdOCI0qeWP1su5PuD3gBkX3iNdmTdE7c cVov377WW5kHCif4HtXxz9T1SYItKkbZW15YwJt173RpBNnQH8oGVRAj79sMtkUHMdv8 Uu+xPZb+gpag1kKTgJG7nCBbi0Cd14Q5NaeyoflVJKaVulJ4VvX1hA6o1uDqsuJTnMIZ LrlmVd8Ekx1YFy2s2okPP0yTC3rgLxkvBfJriuqWtWGqNTXVI8tAuPuqyhl23E9JNE6q lI9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=d5T5DiW1azUMCdgU6fO5gaNT0Ga90Fqig2abiRnRkuA=; b=JKAtwxm9oOJ3fUxkAJwwMJfIiKR1OfZNOCZFQ7JULr8z+ugqjXGKLyRbiwMnodeGuK 15AIgFJpaU/lts4cOd7m6xlMavAiGo1i+wMeBJou1xKwyqWvR7dPaTx6TbRinqNuguX1 KqEeMicAiw2bn96yZENHtjGX83ADLUV2ZJWzOHNH5UCs1m2725I1EuvHFtgYNJZDsTSh A4CCygHmyP49fi62jD6Hiqqs/p2iCgpf9rKskdkzg/UDqoacBA2lTaC3sbcqKg46gqI8 Odow85UpHzMew/JEnK01HnTiOjlsIpbqyAsv0kBIagkGyObS6K87i2CBwSj8AZpPLSpN VYCw== X-Gm-Message-State: AODbwcA2yi6xqjncVL2GRz2F+SFxoGrDeUWSz2fYuEm97918vo/5orAF UWhKYQbtC0peR6hn6r8= X-Received: by 10.84.234.1 with SMTP id m1mr68427869plk.41.1496341641538; Thu, 01 Jun 2017 11:27:21 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x5sm37326323pfi.94.2017.06.01.11.27.20 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Jun 2017 11:27:20 -0700 (PDT) Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_70298DD0-5C10-4996-8206-E9E727E1224C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20170601171642.GA601@FreeBSD.org> Date: Thu, 1 Jun 2017 11:27:18 -0700 Cc: "Simon J. Gerraty" , Marcel Moolenaar , src-committers , svn-src-all@FreeBSD.org, Brooks Davis , svn-src-head@FreeBSD.org, Ngie Cooper Message-Id: References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <84744.1496336318@kaos.jnpr.net> <20170601171642.GA601@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 18:27:22 -0000 --Apple-Mail=_70298DD0-5C10-4996-8206-E9E727E1224C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 1, 2017, at 10:16, Alexey Dokuchaev wrote: >=20 > On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote: >> One option would be to store a sha256 hash of the result. >> If the image generated by the test hashes to the correct value - you >> pass. >=20 > That should be preferred. Storing binary blobs in VCS is bad = practice. >=20 >> Of course if the test fails, you are completely in the dark as to >> how/why. >=20 > Not really: you checkout previous version (which produces correct = hash) > and store generated image for later inspection and diffing. >=20 >> Is storing img-1x1-512-mbr.vmdk.gz any more palatable? >=20 > This is barely acceptable, but only if image was zerofied/sparsed = prior > to compression. Also, the image should be of the minimal (sufficient) > working size. I vote for not checking in the SHAs. If something fails (as = someone else mentioned on the lists), it=E2=80=99s really hard to debug = why it failed. I think marcel@=E2=80=99s proposal for hexdump -C text dumps are = the best way to handle this. Thanks, -Ngie --Apple-Mail=_70298DD0-5C10-4996-8206-E9E727E1224C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZMFyHAAoJEPWDqSZpMIYVOWkP/RiWtIzJXiUBzKzgBvUwbTT+ JFLyYY1F+YqKUJsJLInOzF4rKiO7nVVb0edvr10EYFjkfkttItxwnYZAzrjdbHrc nipBzXmuOgDf0zUy8MHOucvIa+IdQ7fgdcX42dB9r3pb1E7ZTwxd3ju++eW8CWZc u0VlxX5L9/hgA5Q8rh2yS+V1PQt/mNS0iO2cM39JJtr8nhJ5cz6KAPIn0+7bErLq CA4xydgjEsBSZb77oAymE+MpYKsoa2j1HW+qaJUSIfV+dNuaUmM91w4i2E0WjEeV iQ/AierBY0QBtUgjBQZUcMgLp3wOdFQG94HlUnQqs86ejrmFCRj44YGBDH2lubpQ axxu6U0y6ja4R7XQxu1gKZaIrOMkbB2pCHFL0XUV3Iv3uSAt8fam75ZhA8X+xvvZ PGag0NDoDO+v0LS2FazyZpgPuvdSnbiFDN7w3eCH6SOf/o0+/gN4LmD2MB2m9bRc b97ra7RHmEbg1syJTxZVolQFqCNx3j3AX7FIdNKOTXNy8Vgr0Z4AxwjaGATlXKM8 4htHWFfEKzJsa31AID3+PnRacqrlDkruxVhofNMDseoJduwrC3P+G2PP4xXNx8Hy E5XZjfRJZEJu9mJJODffx5Jb7RHyBhSh4g3yh2KTbjEmD/4lHgM3t6tHczP3x68d jLLwfqSS/hufMCaecIWt =YJ/f -----END PGP SIGNATURE----- --Apple-Mail=_70298DD0-5C10-4996-8206-E9E727E1224C--