From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Feb 1 17:27:44 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1F70E531 for ; Sun, 1 Feb 2015 17:27:44 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 06104D33 for ; Sun, 1 Feb 2015 17:27:44 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t11HRhhT039729 for ; Sun, 1 Feb 2015 17:27:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197247] audio/gkrellmvolume2: fix volume reading Date: Sun, 01 Feb 2015 17:27:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: amdmi3@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ume@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2015 17:27:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197247 Bug ID: 197247 Summary: audio/gkrellmvolume2: fix volume reading Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ume@FreeBSD.org Reporter: amdmi3@FreeBSD.org Flags: maintainer-feedback?(ume@FreeBSD.org) Assignee: ume@FreeBSD.org Created attachment 152443 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152443&action=edit Patch gkrellmvolume2 doesn't work correctly: the volume slider jumps back and forth between real volume value and 100%. I don't know OSS well, but it seems like ioctl which reads mixer value doesn't fill resulting value with zeroes, long which is filled by ioctl may contain junk in higher bytes. Therefore, "amount >> 8" used to extract right channel volume would also return junk in addition to needed byte. The fix adds mask to extract only the needed byte. --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer ume@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.