From owner-dev-commits-src-all@freebsd.org Tue Jul 6 19:04:50 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E9E476660A5; Tue, 6 Jul 2021 19:04:50 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GKBnZ5Vvbz4gxl; Tue, 6 Jul 2021 19:04:50 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-qk1-x731.google.com with SMTP id t19so6608899qkg.7; Tue, 06 Jul 2021 12:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5EclEbvOQR0Bml1e8BxOMOHKOp1k1W/bJ11Rlb1SIAI=; b=GZBEs4rsDVmKf5MuBWzmg6d98VPlZP6kEqSRMgh7xnPo14f9lsXrSDtdCWNnnYR40h D5W0T3ohYzEtCyOjGp5iIXPSxOsVb3qW7R5JHyT3mThLmVmIO9nnwDsa1LZhuehHG91w HXEP3Pe+JbsCb/jZmg+QaEd5XjQvTxDxJYU49UpjHddz6w1YsfkNvth2P/p7xHvnNnUn KGK5dYb8qztrBRWO49dZWlAq7tYoCQgt5MOAtMtVk2tw+5ddMTLsDWisaWi5tbnT3nYH XpgQXh5l1FhBildhpPKgV9NBZUW7t9Y1nrwhX5dZ7FUj7/VZV3glZ1R9Uj+Tka7PoVwc spYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5EclEbvOQR0Bml1e8BxOMOHKOp1k1W/bJ11Rlb1SIAI=; b=ieFe/srD8RynDMBJMndudfFmOFsiIiBQFrDw/D7yqTe5SAB124gHKNiJIohc+PdAmP vUJ/bXuaJicgBOkL87pZz6whtVvPI9R4Mk3Ly9zFMlFwRftjHAAt/p0gqPV8x2dtlWfj ezZni9wzwagP5ER216fV2vc4C+Q2Ygx1Dgr5YygZj7L0l4ijB/vq5Uhtb93AqsRq9Gd0 IkmeS5z9WGgegvJftjZRKekrSA8/aljiVbzkXoGXdwsBHt9lsPWWeSuPFh971RBM+GyL 2rk8xYf9hqMed9Y5oEqIsHxHSC+1YgYvx6GLunE1UKk5XkfYEsOgndS0Mqzn1TuU3Vml sECQ== X-Gm-Message-State: AOAM532Kg6rVYG+rmfzxJh5YjHQdAxmpeQmrY727ostq3pLBMdbNGUam vM08qo3vin2/hoLOo/jojtLpsi9fKpk= X-Google-Smtp-Source: ABdhPJw3ltOforn2LqNL+eywirdgGe2O2nhkmsTSyL3gX/cRF5XKZbrVORhzPIWQ8FEJcXK+cR597g== X-Received: by 2002:ae9:f805:: with SMTP id x5mr10181671qkh.373.1625598289295; Tue, 06 Jul 2021 12:04:49 -0700 (PDT) Received: from mavoffice.ixsystems.com ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id t62sm7188292qkc.26.2021.07.06.12.04.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 12:04:48 -0700 (PDT) Subject: Re: git: 29e2dbd42c3e - main - ocs_fc: Add gendump and dump_to_host ioctl command support. To: Kristof Provost , Ram Kishore Vegesna Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202107061548.166Fm2ol078877@gitrepo.freebsd.org> From: Alexander Motin Autocrypt: addr=mavbsd@gmail.com; prefer-encrypt=mutual; keydata= mQENBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAG0IkFsZXhhbmRlciBNb3RpbiA8bWF2YnNkQGdtYWlsLmNvbT6JAVQEEwEKAD4CGwMFCwkI BwMFFQoJCAsFFgMCAQACHgECF4AWIQTpjPPE5pzDzQ5XnVWDGMOVW6sifwUCWWDCtwUJDTHM ogAKCRCDGMOVW6sif7nYB/9TpvgdnxMVBT9aPaaGrFOToI8lV5eCUIB3ot6+VbfeMam0nkFZ GGoaXvDMdIf++1jFADTP+hcl1fIrrH1uy2ZS1tDu3Ngd6BUCAcHcbFEqEZnCwzQTkULHbYGJ pHxKAvQYIvrOTpBb4IBHBO44lOVC21VYj8ii6hTr1ACqYa4SbIaQobByWkWErHNGN9A64LFS rbir4mXJ0Bo0vgfj3jtoGEV8RrbYseYBR2NOaw+1GjRMjoJxyTMgU1XNDZHAVGHiw/KG2cR8 EH4rqj47fLWJLWZy/ffUsWmqDnWvqswbzZjQXT8B4Yls9aqum5pykoNKtbAFT8Xpb/Y9RE1s nkXTuQENBFOzxAwBCADmYFn9nCSLvufCMz9nZFxP7q497a+Dqqwf8hxllH+9S8+g9BYumQF4 A7ZnBSxj3zMlriwL0jPsZqILpO8wuIUQWL0MnJiIbqgatYztVqf2fpaaDzP9XA2C5/BZb5iP 3ONDIVGYd+OQwOI2FlmmTY0B1FlUNXz3+feb3VVTD0/2mxPBOQ2hen0pEZqhU5n2EZH27d8r VPDXVGqQ3CVWO3BD9pyQVTWT5ziDm0f2SIEsY46xuaN+Ml6KnrqfCb8BL/vzcpc87slxGUdR HRCM0P2tZ4f9I+DV7c2RKiluGk1pZkqm+sDfI4dTkjjqpGLH5xN538XGW8YuCEaDUGJZufUf ABEBAAGJATwEGAEKACYCGwwWIQTpjPPE5pzDzQ5XnVWDGMOVW6sifwUCWWDC2AUJDTHMzAAK CRCDGMOVW6sif06oB/0UBwpZL3nBNNutpcCqD/5tDIeCOUy0YKCSZ/EuxtQZ6qIWCZIi6gOs Xurqxg+zqnTQJddlG641m3SVfs73mt7yaDODGbmImKxml1scxV6liXD8DFPbAIfDEYIR7rgu b4D2+OU537cPf/p9IvBn1YUITqnqVBnUIODT3F74kpKAL4oOqafS3MYrJ9IK6FECrdeRnLEv WHEFoN4/R54qXOjLuNeh1/fBW9ddzRyanNoHkxy5EcrgRTqMiKgejfRio8zgCM8cbFXZfU3r 8BrK6eDOP0Rc1m0oLGzp2xO+OeJZrlWRn0XhI51JvER6fUNlFil5ad3sZWY7zqf7lRKQoJc+ tCJBbGV4YW5kZXIgTW90aW4gPG1hdmJzZEBnbWFpbC5jb20+uQENBFOzxAwBCADmYFn9nCSL vufCMz9nZFxP7q497a+Dqqwf8hxllH+9S8+g9BYumQF4A7ZnBSxj3zMlriwL0jPsZqILpO8w uIUQWL0MnJiIbqgatYztVqf2fpaaDzP9XA2C5/BZb5iP3ONDIVGYd+OQwOI2FlmmTY0B1FlU NXz3+feb3VVTD0/2mxPBOQ2hen0pEZqhU5n2EZH27d8rVPDXVGqQ3CVWO3BD9pyQVTWT5ziD m0f2SIEsY46xuaN+Ml6KnrqfCb8BL/vzcpc87slxGUdRHRCM0P2tZ4f9I+DV7c2RKiluGk1p Zkqm+sDfI4dTkjjqpGLH5xN538XGW8YuCEaDUGJZufUfABEBAAGJATwEGAEKACYCGwwWIQTp jPPE5pzDzQ5XnVWDGMOVW6sifwUCWWDC2AUJDTHMzAAKCRCDGMOVW6sif06oB/0UBwpZL3nB NNutpcCqD/5tDIeCOUy0YKCSZ/EuxtQZ6qIWCZIi6gOsXurqxg+zqnTQJddlG641m3SVfs73 mt7yaDODGbmImKxml1scxV6liXD8DFPbAIfDEYIR7rgub4D2+OU537cPf/p9IvBn1YUITqnq VBnUIODT3F74kpKAL4oOqafS3MYrJ9IK6FECrdeRnLEvWHEFoN4/R54qXOjLuNeh1/fBW9dd zRyanNoHkxy5EcrgRTqMiKgejfRio8zgCM8cbFXZfU3r8BrK6eDOP0Rc1m0oLGzp2xO+OeJZ rlWRn0XhI51JvER6fUNlFil5ad3sZWY7zqf7lRKQoJc+ Message-ID: <2b8685de-e94b-9413-b4fd-43526c7903d3@gmail.com> Date: Tue, 6 Jul 2021 15:04:47 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4GKBnZ5Vvbz4gxl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 19:04:51 -0000 On 06.07.2021 14:55, Kristof Provost wrote: > On 6 Jul 2021, at 17:48, Ram Kishore Vegesna wrote: > The branch main has been updated by ram: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=29e2dbd42c3e2e10e606b3414f4d0c53021d4e86 > > commit 29e2dbd42c3e2e10e606b3414f4d0c53021d4e86 > Author: Ram Kishore Vegesna > AuthorDate: 2021-06-24 07:05:00 +0000 > Commit: Ram Kishore Vegesna > CommitDate: 2021-07-06 15:38:11 +0000 > > ocs_fc: Add gendump and dump_to_host ioctl command support. > > Support to generate firmware dump. > > Approved by: mav(mentor) > --- > sys/dev/ocs_fc/ocs_gendump.c | 388 > +++++++++++++++++++++++++++++++++++++++++++ > sys/dev/ocs_fc/ocs_gendump.h | 42 +++++ > sys/dev/ocs_fc/ocs_ioctl.c | 13 +- > sys/dev/ocs_fc/ocs_ioctl.h | 3 + > sys/dev/ocs_fc/ocs_mgmt.c | 152 ++--------------- > sys/dev/ocs_fc/ocs_os.c | 3 +- > sys/dev/ocs_fc/ocs_os.h | 3 +- > sys/modules/ocs_fc/Makefile | 3 +- > 8 files changed, 449 insertions(+), 158 deletions(-) > > I’m seeing this build failure (amd64, GENERIC kernel): > > |ld: error: undefined symbol: ocs_gen_dump >>> referenced by > ocs_mgmt.c:485 (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:485) >>> > ocs_mgmt.o:(ocs_mgmt_exec) ld: error: undefined symbol: ocs_dump_to_host >>>> referenced by ocs_mgmt.c:489 > (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:489) >>> ocs_mgmt.o:(ocs_mgmt_exec) > *** [kernel.full] Error code 1 | > > Does that ring any bells? d0732fa81963 should fix it. Sorry for breakage. -- Alexander Motin