From owner-freebsd-acpi@FreeBSD.ORG Tue May 31 21:43:10 2005 Return-Path: X-Original-To: freebsd-acpi@FreeBSD.org Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AA8D16A41C; Tue, 31 May 2005 21:43:10 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0586243D1D; Tue, 31 May 2005 21:43:09 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j4VLh8Z6017162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 31 May 2005 14:43:08 -0700 Message-ID: <429CDA32.5040208@root.org> Date: Tue, 31 May 2005 14:42:10 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Markus Brueffer References: <200505310155.KAA00994@axe-inc.co.jp> <200505311225.40954.markus@FreeBSD.org> <429C9DB9.4070107@root.org> <200505311935.57158.markus@FreeBSD.org> In-Reply-To: <200505311935.57158.markus@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@FreeBSD.org, freebsd-mobile@FreeBSD.org Subject: Re: Call for testers: New acpi_ibm driver X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2005 21:43:10 -0000 Markus Brueffer wrote: > On Tuesday 31 May 2005 19:24, Nate Lawson wrote: > >>Markus Brueffer wrote: >> >>>On Tuesday 31 May 2005 03:55, takawata@jp.freebsd.org wrote: >>> >>>>In message <200505301857.20346.markus@FreeBSD.org>, Markus Brueffer > > wrote: > > [...] > > >>>>>Support for more hotkeys by the hotkey sysctl (see manpage) >>>>>Improved support of ACPI events, disabled by default. You can enable >>>>>it by setting the events sysctl to 1 (on my T41p there are now 24 >>>>>different keypress events that get reported) >>>>>write support for: volume, mute, brightness and thinklight >>>> >>>>Is it ok to touch EC? I know the two way of impliment it. >>>>One is modifying RTC register, another is using SMI interface >>>>via ACPI control method. >>> >>>Writing to the EC directly is nothing more that accessing the locations >>>via acpi_SetInteger. While I would highly prefer the latter method, the >>>problem is, that several places of the EC in the DSDT aren't even named >>>or only named on some models. >> >>Please do not read/write directly from EC space. A better way is to use >>the EC device methods I added recently. This uses proper locking for >>requests and will work concurrently with other EC users (say, cmbat): >> >> device_t dev; >> >> dev = devclass_get_device(devclass_find("acpi_ec"), 0); >> if (dev == NULL) >> error, EC not present -- check this during probe and fail >> if error >> >> error = ACPI_EC_WRITE(dev, address, buffer, len); >> >>or ACPI_EC_READ(). "address" is from 0-255 (8 bit addresses in EC >>space) and buffer is a pointer to data to write or read. > > > That's what I meant by "directly". The driver uses exactly that way. > > Markus > Thanks, that is the correct way. I didn't have time to review your patch. -- Nate