Date: Wed, 23 Jan 2008 13:39:53 -0600 From: Brooks Davis <brooks@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Rong-En Fan <rafan@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/LPRng Makefile distinfo pkg-descr pkg-plist ports/sysutils/LPRng/files lprng.in pkg-message.in Message-ID: <20080123193953.GA10711@lor.one-eyed-alien.net> In-Reply-To: <47979627.1060405@FreeBSD.org> References: <200801200837.m0K8bNX0081391@repoman.freebsd.org> <4795044E.6030006@FreeBSD.org> <20080122015108.GX4650@svm.csie.ntu.edu.tw> <20080122215109.GD21985@tirith.brixandersen.dk> <47979627.1060405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 23, 2008 at 11:31:51AM -0800, Doug Barton wrote: > Henrik Brix Andersen wrote: >> On Tue, Jan 22, 2008 at 09:51:08AM +0800, Rong-En Fan wrote: >>> On Mon, Jan 21, 2008 at 12:45:02PM -0800, Doug Barton wrote: >>>> The script looks good, thanks for doing this! The only thing I would= =20 >>>> point out is that the default _enable=3Dno is not needed, since rc.sub= r=20 >>>> needs to see one of the values for "yes" in order to do anything. No= =20 >>>> harm leaving it in, I just wanted to point out that it's not strictly= =20 >>>> necessary. >>> Thanks. I see most of our /etc/rc.d/* scripts does not have this. >>> But most ports' have as our Porter's Handbook have such example. >> I believe this is actually required for rc scripts supplied by >> ports. Scripts included in the base wont need it, since their default >> settings are already present in /etc/defaults/rc.conf. >> I just tried removing the default setting for '$bitlbee_enable' in the >> rc script for irc/bitlbee, I did recently. It then results in the >> following error when '$bitlbee_enable' is undefined: >> # /usr/local/etc/rc.d/bitlbee rcvar >> # bitlbee >> /usr/local/etc/rc.d/bitlbee: WARNING: $bitlbee_enable is not set properl= y=20 >> - see rc.conf(5). >> bitlbee_enable=3DNO >=20 > Hrrm, that's annoying. :) Ignore what I said then, if it's doing that (an= d=20 > I don't think it _should_, but that's another issue) then you need the=20 > default. Sorry for the noise. It's done that from day one with rc.d since foo_enable variables are checked with checkyesno(). If we wanted to not have to set them, adding a default argument to checkyesno is certainly easy enough to do following the pattern= in network.subr's get_if_var(), but I'm not sure it would be of much value. -- Brooks --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHl5gIXY6L6fI4GtQRAk0/AJ9O4uMBVol9rP4G3vYo5EC2u5of5ACZAYI5 rg23msEGfoevtIWiUikmPDM= =LoDZ -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080123193953.GA10711>