From owner-freebsd-current@FreeBSD.ORG  Sat Jun  7 08:18:06 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 21BCA106564A;
	Sat,  7 Jun 2008 08:18:06 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 554438FC15;
	Sat,  7 Jun 2008 08:18:05 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <484A443D.8080900@FreeBSD.org>
Date: Sat, 07 Jun 2008 10:18:05 +0200
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
MIME-Version: 1.0
To: freebsd-current@freebsd.org, freebsd-hackers@freebsd.org
References: <20080531143655.GA14020@nobby.studby.ntnu.no>
In-Reply-To: <20080531143655.GA14020@nobby.studby.ntnu.no>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: CFT: CVSMode for csup with MD5 check
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jun 2008 08:18:06 -0000

Ulf Lilleengen wrote:
> Hello,
> 
> As a followup to my previous patch on csup, I've tried to do some fixes to
> RCS-files. However, instead of doing major workarounds in csup to handle
> files which does not behave correctly to RCS, I implemented MD5 check of RCS
> content. This means that the MD5 sum from cvsupd is checked against the
> actual RCS content (which is different from a normal MD5 check, because
> only the content is compared), and if it's not correct, a fixup of the file
> will be sent, thus making sure that the contents are correct. I hope some of
> you are able to test this. 
> 
> There are still a few issues with cvsmode:
> - Not correct entries in status file.
> - I get unnatural high memory usage.
> 
> Patches here:
> http://people.freebsd.org/~lulf/patches/csup/csup_2008-05-31_CURRENT.diff
> and
> http://people.freebsd.org/~lulf/patches/csup/csup_2008-05-31_RELENG_7.diff
> 

This doesn't compile.  There are a bunch of warnings, and rcsfile.c is 
missing from Makefile, but there is an undefined reference:

rcsfile.o(.text+0x1d32): In function `rcsfile_frompath':
: undefined reference to `rcsparse_run'
*** Error code 1

Kris