Date: Mon, 8 Oct 2012 18:02:11 +0100 From: Chris Rees <crees@FreeBSD.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305357 - head/net/ssvnc Message-ID: <CADLo839ndFXumShc1FwM2zrfuq9Htt%2Bvx5c%2Bia%2B=t=1i0Q%2ByoQ@mail.gmail.com> In-Reply-To: <20121008071642.GA91360@ithaqua.etoilebsd.net> References: <201210061123.q96BNHVx053948@svn.freebsd.org> <20121008040154.GB91369@FreeBSD.org> <20121008045905.GD91369@FreeBSD.org> <20121008071642.GA91360@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8 October 2012 08:16, Baptiste Daroussin <bapt@freebsd.org> wrote: > On Mon, Oct 08, 2012 at 04:59:06AM +0000, Alexey Dokuchaev wrote: >> On Mon, Oct 08, 2012 at 04:01:54AM +0000, Alexey Dokuchaev wrote: >> > On Sat, Oct 06, 2012 at 11:23:17AM +0000, Baptiste Daroussin wrote: >> > > New Revision: 305357 >> > > URL: http://svn.freebsd.org/changeset/ports/305357 >> > > >> > > Log: >> > > fix sense of a test >> > > >> > > -.if ${PORT_OPTIONS:MULTRAFTP} >> > > +.if empty(PORT_OPTIONS:MULTRAFTP) >> > >> > That looks weird, and commit message is pretty cryptic as well. Could you >> > explain what went wrong here so others would not fall in the same pitfall? >> >> Err, I read is as ! vs. empty() test. Still, I've noticved some arguments >> on the syntax, would be nice to know if ! ${PORT_OPTIONS:M...} has issues >> other than purely stylish. >> > > No it hasn't (as far as I know) > This is all my fault-- I was the one who suggested the original use of ${FOO:M}, and I deliberately chose to retain empty(FOO) as the reverse because I was convinced that the insanity of make's conditionals would screw us over in some way. I have at [1] pulled together some simple tests, and I think I've caught all use cases here. It seems to work fine-- are there any people more wizardly than me with make that can confirm that it's OK? If so, I'll update the docs. Chris [1] http://www.bayofrum.net/~crees/scratch/Makefile-do-we-need-empty-after-all
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839ndFXumShc1FwM2zrfuq9Htt%2Bvx5c%2Bia%2B=t=1i0Q%2ByoQ>